903965 - nsWebNavigationInfo loads plugins for docShells with allowPlugins=false

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Mark Hammond [:markh] [:mhammond]]

Attachment: Skip loading plugins if the docShell isn't going to use them

nsWebNavigationInfo::IsTypeSupported() loads plugins (and thus the blocklist) even if the request is for a docShell with allowPlugins=false.  While later code avoids using the plugin, we should skip the load in this case.

Normally this shouldn't cause any problems, but currently this causes warnings when done in a child process - see bug 901294.  The attached patch fixes this.

(The evidence of this is the following message printed to the console in debug builds:

***********************************************************
*
* Call to xpconnect wrapped JSObject produced this error:  *
[Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIProperties.get]"
nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: resource://gre/modules/FileUtils.jsm :: FileUtils_getDir :: line 63"  data: no]
************************************************************

and further instrumentation shows this is being called by the plugin manager)

Comment 1

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 788827 [details] [diff] [review]
Skip loading plugins if the docShell isn't going to use them

Georg,
  You were suggested to me as good reviewer of this given Ben's away - I hope that's OK!

Comment 2

[Georg Fritzsche [:gfritzsche]]

Comment on attachment 788827 [details] [diff] [review]
Skip loading plugins if the docShell isn't going to use them

Sorry, i've no insight into docshell.
I see that bz is also on PTO, maybe try jst or smaug as docshell peers?

Comment 3

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 788827 [details] [diff] [review]
Skip loading plugins if the docShell isn't going to use them

Olli, any chance you could take a look at this or pass it on?

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 788827 [details] [diff] [review]
Skip loading plugins if the docShell isn't going to use them

The code should be above IsTypeSupportedInternal.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

er, let me look again.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7e2f89d98860