904 - Implement repeating, prioritised timers on Mac

Status: VERIFIED FIXED

(Core :: DOM: UI Events & Focus Handling, defect, P2)

Description

[troy]

The timer API and implementation doesn't support repeating timers, and this
causes a large number of temporary timer objects to be created and
destroyed; e.g., view mgr, throbber, image system services

Comment 1

[leger]

Setting all current Open Critical and Major to M3

Comment 2

[Paul MacQuiddy]

per leger, assigning QA contacts to all open bugs without QA contacts according
to list at http://bugzilla.mozilla.org/describecomponents.cgi?product=Browser

Comment 3

[vidur (gone)]

This really should not be my responsibility. Does anyone care? If so, they
should do it themselves.

Comment 4

[troy]

Of course people care. If not why would I have bothered to create the bug in the
first place? It's a performance problem

Comment 5

[Christopher Blizzard (:blizzard)]

Attachment: partial repeating timers fix

Comment 6

[Christopher Blizzard (:blizzard)]

On a similar note, in a lot of places timers are being created when there is
nothing to actually do and it's wasting a lot of cpu time.  I've attached a
small patch that will fix it in the viewer executable.  In the case of that
program the timers don't run unless there's an animation actually running ( the
throbber, really ) or there's something being downloaded.

There's still a problem in the layout engine that is creating timers every 25 MS
which gets pretty painful.  I'm not sure how to fix it but I think that someone
who knows the layout engine should have a look.  It's being reset in
nsViewManager::SetFrameRate().

Comment 7

[leger]

Putting on [Perf] radar

Comment 8

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

This is _so_ not vidur's bug.  If nobody in gfx/widget/layout will fix it, I'll
find some patches to turn on repeating timers and slam them in myself.

Comment 9

[troy]

It really is Vidur's bug, after all he did the timer implementation. And it's
not like we never had repeating timers; we've had them in every single shipping
product

Comment 10

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Fair enough, I guess.  Vidur can't really fix this, because it needs someone to
hack on each of the widget/timer implmentations.  I'll try to find people to do
that.

Comment 11

[chris hofmann]

m12

Comment 12

[chris hofmann]

m14.  let me know if this has autommagically become available before.

Comment 13

[leger]

Bulk add of "perf" to new keyword field.  This will replace the [PERF] we were
using in the Status Summary field.

Comment 14

[alla]

Repeating timers are now implemented for windows and unix in bug #22979.
There is also skeleton code for mac and others.
I think this should go in. This is the second time I've implemented repeating
timers in Gtk+, and it's badly needed.

Comment 15

[alla]

Added me to CC.

Comment 16

[troy]

I think it should go in, too

Comment 17

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

This is a dup of 22979, really, and there's no point keeping it open.


*** This bug has been marked as a duplicate of 22979 ***

Comment 18

[Michael Lowe]

Actually, after 22979 has been fixed there is still a need to get the new timer
features implemented on Mac.   Reopening bug, so this task can be assigned to
a Mac person.

Comment 19

[leger]

Clearing DUPLICATE resolution due to reopen.

Comment 20

[Simon Fraser [no longer active]]

obligatory comment

Comment 21

[Peter Trudelle]

removing vestigial tags, putting on beta1 radar per beta criteria priority #2. 
Can anyone comment on how much affect this has on the Mac's glacial performance?

Comment 22

[Peter Trudelle]

cc'ing waterson

Comment 23

[Simon Fraser [no longer active]]

Attachment: irc log

Comment 24

[Chris Waterson]

sweet jesus, what does this bug mean, and who is going to do the work?

Comment 25

[Simon Fraser [no longer active]]

I know what the bug means, chris, and i can do the work. Most of the code can be 
cloned from the windows implementation.

Comment 26

[leger]

Putting on PDT- radar for beta1.  Would like to get in, but would not hold beta 
for this.

Comment 27

[Simon Fraser [no longer active]]

I'm not going to get to this by M14

Comment 28

[Simon Fraser [no longer active]]

I checked in an implementation of repeating/prioritized timers for the Mac.

Comment 29

[Madhur Bhatia]

QA contact updated

Comment 30

[luis rincon]

verified on build 2001-07-24-07-trunk