904012 - remove a bogus assertion from ThebesLayerBuilder

Status: RESOLVED FIXED

Description

[Nick Cameron [:nrc]]

Comment 1

[Nick Cameron [:nrc]]

Created attachment 788871 [details] [diff] [review]
patch

This assertion is bogus. It asserts that we should not have an azure buffer when we have a thebes dest buffer. The situation arises because we start with no texture client, therefore we cannot tell whether it will be safe to use Azure and we ere on the side of caution and say no. Thus we create destBuffer, rather than destDTBuffer. In the process of creating destBuffer, we create a texture host. If that texture host can support Azure, then we fail this assert. But there is nothing wrong. And on the next frame we will get an azure buffer as expected (because in EndPaint we call SetBufferProvider(nullptr) which nulls out mBuffer and mDTBuffer so we will request a DrawTarget.

Please lets kill Thebes here asap.

Comment 2

[Nick Cameron [:nrc]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/50d2adb2f34d

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/50d2adb2f34d