Closed Bug 904140 Opened 8 years ago Closed 8 years ago

Trace actor omits completion value property when returning undefined

Categories

(DevTools :: General, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 26

People

(Reporter: rjacob, Unassigned)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

When a completion value (return/throw/yield) for a frame is undefined, the trace actor sends an exitedFrame packet with no completion value at all. The packet should use a value grip for undefined in this situation ("return":{"type":"undefined"}).
Attached patch bug-904140 (obsolete) — Splinter Review
Attachment #789043 - Flags: review?(nfitzgerald)
Comment on attachment 789043 [details] [diff] [review]
bug-904140

Review of attachment 789043 [details] [diff] [review]:
-----------------------------------------------------------------

Regression test and try push needed ;)
Attachment #789043 - Flags: review?(nfitzgerald) → review-
Attached patch bug-904140Splinter Review
Try push: https://tbpl.mozilla.org/?tree=Try&rev=2d475651e142
Attachment #789043 - Attachment is obsolete: true
Attachment #789235 - Flags: review?(nfitzgerald)
Blocks: 887204
No longer blocks: 887204
Blocks: 887024
Comment on attachment 789235 [details] [diff] [review]
bug-904140

Review of attachment 789235 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, Jake!

Feel free to whiteboard [land-in-fx-team] once the try push comes back green.
Attachment #789235 - Flags: review?(nfitzgerald) → review+
Whiteboard: land-in-fx-team
Whiteboard: land-in-fx-team → [land-in-fx-team]
https://hg.mozilla.org/integration/fx-team/rev/8168210612eb
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/8168210612eb
Status: NEW → RESOLVED
Closed: 8 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 26
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.