Closed
Bug 904140
Opened 12 years ago
Closed 12 years ago
Trace actor omits completion value property when returning undefined
Categories
(DevTools :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 26
People
(Reporter: rjacob, Unassigned)
References
Details
Attachments
(1 file, 1 obsolete file)
|
12.44 KB,
patch
|
fitzgen
:
review+
|
Details | Diff | Splinter Review |
When a completion value (return/throw/yield) for a frame is undefined, the trace actor sends an exitedFrame packet with no completion value at all. The packet should use a value grip for undefined in this situation ("return":{"type":"undefined"}).
|
Reporter | |
Comment 1•12 years ago
|
||
Attachment #789043 -
Flags: review?(nfitzgerald)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 789043 [details] [diff] [review]
bug-904140
Review of attachment 789043 [details] [diff] [review]:
-----------------------------------------------------------------
Regression test and try push needed ;)
Attachment #789043 -
Flags: review?(nfitzgerald) → review-
|
|
Reporter | |
Comment 3•12 years ago
|
||
Attachment #789043 -
Attachment is obsolete: true
Attachment #789235 -
Flags: review?(nfitzgerald)
|
|
||
Comment 4•12 years ago
|
||
Comment on attachment 789235 [details] [diff] [review]
bug-904140
Review of attachment 789235 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks, Jake!
Feel free to whiteboard [land-in-fx-team] once the try push comes back green.
Attachment #789235 -
Flags: review?(nfitzgerald) → review+
|
|
Reporter | |
Updated•12 years ago
|
Whiteboard: land-in-fx-team
|
|
Reporter | |
Updated•12 years ago
|
Whiteboard: land-in-fx-team → [land-in-fx-team]
|
|
||
Comment 5•12 years ago
|
||
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
|
||
Comment 6•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 26
|
||
Updated•7 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•