904163 - [MP] Defect - Sometimes selected text doesn't highlight in text inputs

Status: RESOLVED FIXED

(Firefox for Metro Graveyard :: Input, defect, P2)

Description

[Samvedana (:Samvedana)]

User Agent: Mozilla/5.0 (Windows NT 6.2; Win64; x64; rv:26.0) Gecko/20100101 Firefox/26.0
Build ID: 20130812030209
Built from http://hg.mozilla.org/mozilla-central/rev/87c1796bc46c

STR:
1. Press any text input. You should see context menu.
2. Click "select" in context menu.

Expected result:
Text should be selected with two monocles. The selected text should be highlighted.

Actual result:
The text was selected, but it was not highlighted. Monocles could be expanded to right and left.

Comment 1

[Samvedana (:Samvedana)]

Attachment: selection monocle.jpg

Comment 2

[Jim Mathies [:jimm]]

Attachment: fix

Comment 3

[Allison Naaktgeboren :ally]

Comment on attachment 790232 [details] [diff] [review]
fix

Review of attachment 790232 [details] [diff] [review]:
-----------------------------------------------------------------

Since I don't have touch hardware, I'll trust you to test this, and make sure it doesn't break any existing tests.:)

::: browser/metro/base/content/helperui/SelectionHelperUI.js
@@ +382,2 @@
>     * openEditSession
>     * 

..could you make this whitespace go away while we're here?

@@ +404,5 @@
>    },
>  
>    /*
>     * attachEditSession
>     * 

...and this one?

Comment 4

[Jim Mathies [:jimm]]

This needs a test.

Comment 5

[Jim Mathies [:jimm]]

Attachment: test

ride along with a previous test. I also removed an old extended timeout that got set back before we fixed that 10% cpu drain bug.

Comment 6

[Allison Naaktgeboren :ally]

Comment on attachment 790712 [details] [diff] [review]
test

Review of attachment 790712 [details] [diff] [review]:
-----------------------------------------------------------------

Makes me feel all warm & fuzzy inside.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b80cb9431184