[MP] Defect - Sometimes selected text doesn't highlight in text inputs

RESOLVED FIXED in Firefox 26

Status

Firefox for Metro
Input
P2
normal
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: Samvedana, Assigned: jimm)

Tracking

25 Branch
Firefox 26
x86_64
Windows 8.1
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [preview] feature=defect c=tbd u=tbd p=1)

Attachments

(3 attachments)

(Reporter)

Description

5 years ago
User Agent: Mozilla/5.0 (Windows NT 6.2; Win64; x64; rv:26.0) Gecko/20100101 Firefox/26.0
Build ID: 20130812030209
Built from http://hg.mozilla.org/mozilla-central/rev/87c1796bc46c

STR:
1. Press any text input. You should see context menu.
2. Click "select" in context menu.

Expected result:
Text should be selected with two monocles. The selected text should be highlighted.

Actual result:
The text was selected, but it was not highlighted. Monocles could be expanded to right and left.
(Reporter)

Comment 1

5 years ago
Created attachment 789064 [details]
selection monocle.jpg

Updated

5 years ago
Whiteboard: [preview-triage] feature=defect c=tbd u=tbd p=0

Updated

5 years ago
Blocks: 838081
No longer blocks: 859003
(Assignee)

Updated

5 years ago
Summary: Defect - Sometimes selected text doesn't highlight → Defect - Sometimes selected text doesn't highlight in text inputs

Updated

5 years ago
Blocks: 899390
Summary: Defect - Sometimes selected text doesn't highlight in text inputs → [MP] Defect - Sometimes selected text doesn't highlight in text inputs
Whiteboard: [preview-triage] feature=defect c=tbd u=tbd p=0 → [preview] feature=defect c=tbd u=tbd p=0
(Assignee)

Updated

5 years ago
Blocks: 898799
Whiteboard: [preview] feature=defect c=tbd u=tbd p=0 → [preview] feature=defect c=tbd u=tbd p=1
(Assignee)

Comment 2

5 years ago
Created attachment 790232 [details] [diff] [review]
fix
Assignee: nobody → jmathies
Attachment #790232 - Flags: review?(ally)

Updated

5 years ago
No longer blocks: 838081
Status: NEW → ASSIGNED
Priority: -- → P2
QA Contact: jbecerra
Comment on attachment 790232 [details] [diff] [review]
fix

Review of attachment 790232 [details] [diff] [review]:
-----------------------------------------------------------------

Since I don't have touch hardware, I'll trust you to test this, and make sure it doesn't break any existing tests.:)

::: browser/metro/base/content/helperui/SelectionHelperUI.js
@@ +382,2 @@
>     * openEditSession
>     * 

..could you make this whitespace go away while we're here?

@@ +404,5 @@
>    },
>  
>    /*
>     * attachEditSession
>     * 

...and this one?
Attachment #790232 - Flags: review?(ally) → review+
(Assignee)

Comment 4

5 years ago
This needs a test.
(Assignee)

Comment 5

5 years ago
Created attachment 790712 [details] [diff] [review]
test

ride along with a previous test. I also removed an old extended timeout that got set back before we fixed that 10% cpu drain bug.
Attachment #790712 - Flags: review?(ally)
Comment on attachment 790712 [details] [diff] [review]
test

Review of attachment 790712 [details] [diff] [review]:
-----------------------------------------------------------------

Makes me feel all warm & fuzzy inside.
Attachment #790712 - Flags: review?(ally) → review+
https://hg.mozilla.org/mozilla-central/rev/b80cb9431184
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 26
OS: Windows 8 Metro → Windows 8.1
You need to log in before you can comment on or make changes to this bug.