Closed Bug 904169 Opened 12 years ago Closed 7 years ago

l10n should allow i18n of fullName and description fields in package.json / install.rdf

Categories

(Add-on SDK Graveyard :: General, defect, P2)

defect

Tracking

(Not tracked)

RESOLVED INCOMPLETE

People

(Reporter: artbasher, Unassigned)

References

Details

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/27.0.1453.93 Safari/537.36 Steps to reproduce: There is nothing about this in the documentation, but these fields are definitely i18n capeable - https://developer.mozilla.org/en-US/docs/Localizing_extension_descriptions These seem like pretty important things to i18nize to me?
Component: Jetpack SDK → General
Product: Mozilla Labs → Add-on SDK
Alex, what do you think?
Flags: needinfo?(poirot.alex)
Sounds like a reasonable request! We are missing some code over here: https://github.com/mozilla/addon-sdk/blob/master/python-lib/cuddlefish/rdf.py#L115-L180 In order to set this <em:localized> fragment in the install.rdf out of data from the properties files. `gen_manifest` should be given `harness_options` from __init__.py and iterate over locales with something like this: https://github.com/mozilla/addon-sdk/blob/master/python-lib/cuddlefish/xpi.py#L147-L149 for language in sorted(harness_options['locale']): locale = harness_options['locale'][language] Then we should define a set of magic keys for properties files that we will look for in order to define addon name and description per locale.
Flags: needinfo?(poirot.alex)
(In reply to Alexandre Poirot (:ochameau) from comment #2) > Sounds like a reasonable request! > > We are missing some code over here: > https://github.com/mozilla/addon-sdk/blob/master/python-lib/cuddlefish/rdf. > py#L115-L180 > > In order to set this <em:localized> fragment in the install.rdf out of data > from the properties files. > `gen_manifest` should be given `harness_options` from __init__.py and > iterate over locales with something like this: > https://github.com/mozilla/addon-sdk/blob/master/python-lib/cuddlefish/xpi. > py#L147-L149 > for language in sorted(harness_options['locale']): > locale = harness_options['locale'][language] So the plan in bug 915376 is to remove the install.rdf, and I'd like to avoid adding a `localized` key to package.json if possible. I figure we can follow the method described in https://developer.mozilla.org/en-US/docs/Mozilla/Localization/Localizing_extension_descriptions?redirectlocale=en-US&redirectslug=Localizing_extension_descriptions#Localizing_before_Gecko_1.9 and either automatically set the prefs listed, or bypass the need for these prefs if possible. > Then we should define a set of magic keys for properties files that we will > look for in order to define addon name and description per locale. The special keys that we can used are defined in https://developer.mozilla.org/en-US/docs/Mozilla/Localization/Localizing_extension_descriptions?redirectlocale=en-US&redirectslug=Localizing_extension_descriptions#Localizing_before_Gecko_1.9
Status: UNCONFIRMED → RESOLVED
Closed: 7 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.