Closed Bug 904178 Opened 9 years ago Closed 9 years ago

Cleanup includes in nsPIDOMWindow.h

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla26

People

(Reporter: Ms2ger, Assigned: Ms2ger)

References

(Blocks 1 open bug)

Details

Attachments

(6 files)

Bug 901132 comment 11 reports the following criticalities:

  1851 dom/interfaces/xul/nsIDOMXULCommandDispatcher.idl
  1849 dom/interfaces/base/nsIDOMLocation.idl
  1226 dom/interfaces/core/nsIDOMDocument.idl
   560 dom/interfaces/core/nsIDOMElement.idl
    25 netwerk/base/public/nsIURI.idl
Attachment #789609 - Flags: review?(surkov.alexander)
Comment on attachment 789609 [details] [diff] [review]
Part a: Use nsIDocument in logging::DocLoad

Review of attachment 789609 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/src/base/Logging.cpp
@@ +396,5 @@
>      MsgEnd();
>      return;
>    }
>  
> +  nsCOMPtr<nsIDocument> documentNode = window->GetDoc();

you don't need nsCOMPtr
Attachment #789609 - Flags: review?(surkov.alexander) → review+
Attachment #789617 - Flags: review? → review?(smichaud)
Attachment #789610 - Flags: review?(bugs) → review+
Attachment #789617 - Flags: review?(smichaud) → review+
Blocks: includehell
Attachment #789614 - Flags: review?(wchen) → review+
Comment on attachment 789621 [details] [diff] [review]
Part f: Remove some includes from nsPIDOMWindow.h

Review of attachment 789621 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks :)
Attachment #789621 - Flags: review?(mounir) → review+
Attachment #789618 - Flags: review?(dzbarsky) → review+
Depends on: 908118
https://hg.mozilla.org/mozilla-central/rev/625ec8bb4155
https://hg.mozilla.org/mozilla-central/rev/c50cc0eeb5da
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.