904178 - Cleanup includes in nsPIDOMWindow.h

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Bug 901132 comment 11 reports the following criticalities:

  1851 dom/interfaces/xul/nsIDOMXULCommandDispatcher.idl
  1849 dom/interfaces/base/nsIDOMLocation.idl
  1226 dom/interfaces/core/nsIDOMDocument.idl
   560 dom/interfaces/core/nsIDOMElement.idl
    25 netwerk/base/public/nsIURI.idl

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part a: Use nsIDocument in logging::DocLoad

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part b: Use nsIDocument in nsEventListenerManager::SetEventHandler

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part c: Use nsIDocument in UndoManager::DispatchTransactionEvent

Comment 4

[alexander :surkov (:asurkov)]

Comment on attachment 789609 [details] [diff] [review]
Part a: Use nsIDocument in logging::DocLoad

Review of attachment 789609 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/src/base/Logging.cpp
@@ +396,5 @@
>      MsgEnd();
>      return;
>    }
>  
> +  nsCOMPtr<nsIDocument> documentNode = window->GetDoc();

you don't need nsCOMPtr

Comment 5

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part d: Use nsIDocument in nsMenuItemIconX::GetIconURI

Comment 6

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part e: Make it possible to include nsIDocument.h on its own

Comment 7

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part f: Remove some includes from nsPIDOMWindow.h

Comment 8

[Mounir Lamouri (:mounir)]

Comment on attachment 789621 [details] [diff] [review]
Part f: Remove some includes from nsPIDOMWindow.h

Review of attachment 789621 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks :)

Comment 9

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/4aa0ac960f13
https://hg.mozilla.org/mozilla-central/rev/93500f208103
https://hg.mozilla.org/mozilla-central/rev/9481576bf939
https://hg.mozilla.org/mozilla-central/rev/3c61cc01a3b1

Comment 10

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/625ec8bb4155
https://hg.mozilla.org/mozilla-central/rev/c50cc0eeb5da