904220 - [Clock] Unit tests should not create actual alarm records

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Clock, defect)

Description

[Rick Waldron [:rwaldron]]

...Or at least they should clean-up/remove any that are created.

Comment 1

[Rick Waldron [:rwaldron]]

Attachment: Github Pull Request https://github.com/mozilla-b2g/gaia/pull/11498

- Reorders require files alphabetically
- Adds Mocks: 
    - mock_alarm_list.js
    - mock_alarm_manager.js
    - mock_navigator_mozl10n.js
- Update tests to use actual markup as fixture
- Update tests to use the same mocha API as other tests
- Use mocks instead of creating real alarm records
- Use sinon sandbox features

Comment 2

[Mike Pennisi [:jugglinmike]]

Comment on attachment 789220 [details] [review]
Github Pull Request https://github.com/mozilla-b2g/gaia/pull/11498

Hey Rick,

I've left some comments on GitHub. I also noticed that the TravisCI build was failing, and I was able to reproduce the failures locally.

I took some time to investigate, and I found that the failures originated from the new call to `loadBodyHTML`. I've fixed the bug--I'll attach a patch for it here in just a moment.

Comment 3

[Mike Pennisi [:jugglinmike]]

Attachment: Bug-904220-patch-for-patch.patch

Rick:

This patch addresses the test failures in your patch. The solution I found is sub-optimal, though, so I described the problem and my rationale in the commit message. Feel free to try other approaches to solve this!

Comment 4

[Rick Waldron [:rwaldron]]

Merged Mike's changes.

@ian This won't merge cleanly with https://github.com/rwldrn/gaia/commit/272953c2381d7dda4c9113a44f5d19ccc1800692 but the differences are minor and I've already walked through the conflict resolution once with successful results. If you r+ this, I will be able to merge them both into master tomorrow

Comment 5

[[e-mail], [e-mail]]

Comment on attachment 789220 [details] [review]
Github Pull Request https://github.com/mozilla-b2g/gaia/pull/11498

It's okay for me. Thanks.

Comment 6

[Rick Waldron [:rwaldron]]

Nominating for koi+

Tests only
No risk

Comment 7

[Rick Waldron [:rwaldron]]

gaia@master https://github.com/mozilla-b2g/gaia/commit/56edfdc006c89085a9b8887002843eefe904eb31

Comment 8

[Tony Chung [:tchung]]

dont need to block on tests, and already landed on master

Comment 9

[Rick Waldron [:rwaldron]]

(In reply to Tony Chung [:tchung] from comment #8)
> dont need to block on tests, and already landed on master

But koi+ features will have tests that build off the same file and changes.

Comment 10

[Stephany Wilkes]

Clearing the UX request since it no longer applies.