Closed
Bug 904333
Opened 11 years ago
Closed 11 years ago
Add forEachRequest method to DOMRequestIpcHelper
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla26
People
(Reporter: kanru, Assigned: kanru)
References
Details
Attachments
(1 file, 1 obsolete file)
|
1.21 KB,
patch
|
kanru
:
review+
|
Details | Diff | Splinter Review |
In MozKeyboard.js we need to invalidate all PromiseResolvers in the destroy() method. Currently we iterate through this._requests. It looks ugly and breaks the encapsulation.
Blocks: 899073
|
Assignee | |
Comment 1•11 years ago
|
||
|
||
Comment 2•11 years ago
|
||
Comment on attachment 789367 [details] [diff] [review]
0001-Bug-904333-Add-forEach-Request-PromiseResolver-metho.patch
Review of attachment 789367 [details] [diff] [review]:
-----------------------------------------------------------------
r=me with comment addressed
::: dom/base/DOMRequestHelper.jsm
@@ +226,5 @@
> + if (self.getPromiseResolver(k) instanceof self._window.PromiseResolver) {
> + aCallback(k);
> + }
> + });
> + },
you can do forEach(function(k){....}, this) and get rid of |self| in both methods.
|
|
Assignee | |
Comment 3•11 years ago
|
||
Attachment #789367 -
Attachment is obsolete: true
Attachment #789367 -
Flags: review?(fabrice)
Attachment #789994 -
Flags: review+
|
|
Assignee | |
Comment 4•11 years ago
|
||
|
||
Comment 5•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•