904333 - Add forEachRequest method to DOMRequestIpcHelper

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Kan-Ru Chen [:kanru] (UTC+9)]

In MozKeyboard.js we need to invalidate all PromiseResolvers in the destroy() method. Currently we iterate through this._requests. It looks ugly and breaks the encapsulation.

Comment 1

[Kan-Ru Chen [:kanru] (UTC+9)]

Attachment: 0001-Bug-904333-Add-forEach-Request-PromiseResolver-metho.patch

Comment 2

[[:fabrice] Fabrice Desré]

Comment on attachment 789367 [details] [diff] [review]
0001-Bug-904333-Add-forEach-Request-PromiseResolver-metho.patch

Review of attachment 789367 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with comment addressed

::: dom/base/DOMRequestHelper.jsm
@@ +226,5 @@
> +      if (self.getPromiseResolver(k) instanceof self._window.PromiseResolver) {
> +        aCallback(k);
> +      }
> +    });
> +  },

you can do forEach(function(k){....}, this) and get rid of |self| in both methods.

Comment 3

[Kan-Ru Chen [:kanru] (UTC+9)]

Attachment: 0001-Bug-904333-Add-forEach-Request-PromiseResolver-metho.patch

Comment 4

[Kan-Ru Chen [:kanru] (UTC+9)]

https://hg.mozilla.org/integration/b2g-inbound/rev/9c81d7bd3981

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9c81d7bd3981