904525 - [Buri][TOR]Voice mail notification in status bar disappear without dial to voicemail

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect, P1)

Description

[sync-1]

AU_LINUX_GECKO_ICS_STRAWBERRY.01.01.00.019.184
 Firefox os  v1.1
 Mozilla build ID:20130806071254
 
 DEFECT DESCRIPTION:
 Voice mail notification in status bar disappear without dial to voicemail
 
  REPRODUCING PROCEDURES:
 -receives voice mail
 -phone notify in status bar about new voice mail
 -select the notification in order to check it
 -nothing happend and notification is deleted
 
  EXPECTED BEHAVIOUR:
 When user select the notification phone should dial to voice mail, after to check voicemail notification should delet
 
  ASSOCIATE SPECIFICATION:
 
  TEST PLAN REFERENCE:
 
  TOOLS AND PLATFORMS USED:
 
  USER IMPACT:
 
  REPRODUCING RATE:
 
  For FT PR, Please list reference mobile's behavior:

Comment 1

[sync-1]

Clone from brother

Comment 2

[sync-1]

Attachment: video part4

Comment 3

[sync-1]

Clone from brother

Comment 4

[sync-1]

Attachment: video part3

Comment 5

[sync-1]

Clone from brother

Comment 6

[Mingming ZHAO]

Attachment: patch

Dears,

I investigated this bug, found that it is because of the code "https://github.com/mozilla-b2g/gaia/blob/v1-train/apps/system/js/voicemail.js#L43"

"voicemailNumber" is null so this issue happen.

I have a patch to solve it, please refer to the attachment. Hope it can help you.

Comment 7

[sync-1]

Attachment: video part1

Comment 8

[sync-1]

Attachment: video part3

Comment 9

[sync-1]

Clone from brother

Comment 10

[sync-1]

Attachment: video part4

Comment 11

[Mingming ZHAO]

I have a patch to solve it, please refer to the attachment. Hope it can help you.

Comment 12

[Lukas Blakk [:lsblakk] use ?needinfo]

Looking at the code it would appear this is a regression since v1.0.1 so blocking for a fix.

Comment 13

[Mingming ZHAO]

Hi,how about this issue now?

Comment 14

[Joe Cheng [:jcheng] (please needinfo)]

hi Tim, can you have someone look into this? Thanks

Comment 15

[(inactive after 6/18) Alive Kuo [:alive]]

I will check this later.

Comment 16

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 789492 [details] [diff] [review]
patch

Review of attachment 789492 [details] [diff] [review]:
-----------------------------------------------------------------

Hi contributor,
I wonder why mozVoicemail is null but settings['ril.iccInfo.mbdn'] is not?
Because it's set by https://github.com/mozilla-b2g/gaia/pull/10076/files#L2R578

Comment 17

[Mingming ZHAO]

Hi Alive,

I am not sure why mozVoicemail is null also.I just found it is null when I debug this issue.So I used the code "request.result['ril.iccInfo.mbdn']" to get the number.

Comment 18

[(inactive after 6/18) Alive Kuo [:alive]]

After checking with Vicamo,
voicemail.number may be null if SIM card doesn't provide MBDN info.
I suspect you're using customized voicemail number which is storing in ril.iccInfo.mbdn

Comment 19

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 789492 [details] [diff] [review]
patch

Review of attachment 789492 [details] [diff] [review]:
-----------------------------------------------------------------

Hi, Mingming
Could you file a pull request for this and I could merge for you? Thanks for contributing.

::: apps/system/js/voicemail.js
@@ +43,1 @@
>  

Add comment here.
// Fetch voicemail number from 'ril.iccInfo.mbdn' settings before looking up navigator.mozVoicemail.number
// Some SIM card may not provide MBDN info but we could still use settings to overload that.

@@ +51,5 @@
> +      var number = request.result['ril.iccInfo.mbdn'];
> +      var voicemail = navigator.mozVoicemail;
> +      if (!number && voicemail && voicemail.number) {
> +        number = voicemail.number;
> +      }

if (!number)
  number = (voicemail && voicemail.number) ? voicemail.number : '';

Comment 20

[Mingming ZHAO]

Hi Alive, could you help me merge this patch? I can not download the code "mozilla-b2g/gaia" from github. And please change the assignee to you, I do not know how to fill in the bug status and others. Thanks a lot!:-)

Comment 21

[(inactive after 6/18) Alive Kuo [:alive]]

(In reply to Mingming ZHAO from comment #20)
> Hi Alive, could you help me merge this patch? I can not download the code
> "mozilla-b2g/gaia" from github. And please change the assignee to you, I do
> not know how to fill in the bug status and others. Thanks a lot!:-)

As your wish. Thanks!

Comment 22

[(inactive after 6/18) Alive Kuo [:alive]]

master

https://github.com/mozilla-b2g/gaia/commit/72d9989f759099632c3d3b8b5335b7d12d969d2f

Thanks!

Comment 23

[Mingming ZHAO]

Dear Alive,

Find another issue, why the voicemail notification only can receive once? 

STR: 
1.Receive a voicemail notification 
2.Click it, dial the voicemail number
3.Send a voicemail from other phone
4.The FFOS phone can not receive the voicemail notification

Comment 24

[(inactive after 6/18) Alive Kuo [:alive]]

(In reply to Mingming ZHAO from comment #23)
> Dear Alive,
> 
> Find another issue, why the voicemail notification only can receive once? 
> 
> STR: 
> 1.Receive a voicemail notification 
> 2.Click it, dial the voicemail number
> 3.Send a voicemail from other phone
> 4.The FFOS phone can not receive the voicemail notification

New issue in new bug, thanks. And honestly we don't have a better way to test voicemail in real device....ping vicamo.

Comment 25

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 72d9989f759099632c3d3b8b5335b7d12d969d2f to:
v1-train: f7a6ecac00d178167691728b9179ef140822dda7

Comment 26

[Tim Guan-tin Chien [:timdream] (please needinfo)]

v1.1.0hd: f7a6ecac00d178167691728b9179ef140822dda7

Comment 27

[sarsenyev]

The issue no longer reproduces on Leo COM RIL 1.1
A user is able to access the voicemail after the voicemail message notification is appeared in the notification bar

Environmental  Variables:
Build ID: 20130904041204
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/307824edadd7
Gaia: d0a415bbf23e5d01c2b287d9fca708e167cfe70d
Platform Version: 18.1
RIL Version: 01.01.00.019.212
Firmware revision: D300f10a