904544 - hold wakelock to make sure input devices event can be handle before suspend

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Gonk, defect)

Description

[viral [:viralwang]]

Attachment: add wakelock in EventHub.cpp to make sure the input events can process before suspend

There's one case that we may not handle the input event in time:

when we keep pressing power key continually, we can not make sure what status the device is.
When device is in suspend process and power key event comes after "Freezing user space processes", InputReader will not have chance to handle the power key immediately.
The power key can only process when device exit suspend, it could be long time after power key actually pressed.

The solution here is to sync the latest EventHub.cpp to add wakelock when event reported, it will make sure the InputReader can get event before suspend.

Comment 1

[Michael Wu [:mwu]]

Does bug 908797 do what you need? There's a EVIOCSSUSPENDBLOCK in there. If so, please dup to that bug.

Comment 2

[Michael Wu [:mwu]]

Though, if we need this for helix, I can review this as a 1.1hd only patch, since bug 908797 is too much to backport for helix.

Comment 3

[Wayne Chang [:wchang]]

Michael, can you help to review this patch? We'll likely need it for helix.

Do you feel it'll be required for leo as well or can we do without this on leo? 
My understanding was that it's not a device specific bug.

Comment 4

[Michael Wu [:mwu]]

I'll review it as a 1.1hd only patch. This is a subset of the work being done for bug 908797.

I don't know if leo will need it.

Comment 5

[Michael Wu [:mwu]]

Comment on attachment 789510 [details] [diff] [review]
add wakelock in EventHub.cpp to make sure the input events can process before suspend

r=me *only* for 1.1hd. Do not land on master/1.2.

Comment 6

[viral [:viralwang]]

Attachment: hold wakelock to make sure input devices event can be handle before suspend (final)

modify the comment of patch for landing, hd only.

Comment 7

[viral [:viralwang]]

Please land on hd only since master will use bug 908797 for tracking.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/7eadbb66c48f

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Just use the bug keyword :)

Comment 10

[Ryan VanderMeulen [:RyanVM]]

And I can't read, sorry. Note that this can't land on v1.1hd until it has hd+ blocking status anyway, so please hold off on requesting checkin until then.

Backed out.
https://hg.mozilla.org/integration/b2g-inbound/rev/507d464fd1f1

Comment 11

[Wayne Chang [:wchang]]

hd+ for device specific bug/patch.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18_v1_1_0_hd/rev/8c326236a729