904631 - "System JS : ERROR jar:file:///system/b2g/omni.ja!/components/WifiWorker.js:2889 TypeError: this._stateRequests is undefined" in green B2G mochitest-4 runs

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Wifi, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

Due to recent improvements in the TBPL log parser, we are catching JS exceptions that previously went unnoticed. While they are currently just a source of logspam, we are intending to eventually make these errors fatal. Vincent, can you please look into this error?

https://tbpl.mozilla.org/php/getParsedLog.php?id=26488320&tree=B2g-Inbound

08:01:13     INFO -  10253 INFO TEST-START | /tests/dom/settings/tests/test_settings_data_uris.html
08:01:13     INFO -  10254 INFO TEST-PASS | /tests/dom/settings/tests/test_settings_data_uris.html | Valid blob
08:01:13     INFO -  10255 INFO TEST-PASS | /tests/dom/settings/tests/test_settings_data_uris.html | Valid blob
08:01:13     INFO -  System JS : ERROR jar:file:///system/b2g/omni.ja!/components/WifiWorker.js:2889
08:01:13     INFO -                       TypeError: this._stateRequests is undefined

Thanks!

Comment 1

[Vincent Chang[:vchang][changyihsin]]

Attachment: Patch for mc v1.0

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 791200 [details] [diff] [review]
Patch for mc v1.0

Good catch.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f0dbbb282b5f

Comment 4

[Vincent Chang[:vchang][changyihsin]]

Thanks for your help, Ryan.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

And because once just wasn't enough, re-pushed due to me accidentally overwriting this change when resolving a merge conflict. Fail.
https://hg.mozilla.org/integration/mozilla-inbound/rev/ce33bf6e6258

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/f0dbbb282b5f
https://hg.mozilla.org/mozilla-central/rev/ce33bf6e6258