Closed Bug 904674 Opened 7 years ago Closed 7 years ago

GC: Don't trace additional roots from the embedding on minor GC

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla26

People

(Reporter: jonco, Assigned: jonco)

Details

Attachments

(1 file)

We don't want or need to trace the browser roots on a minor GC.
Attachment #789658 - Flags: review?(wmccloskey)
Comment on attachment 789658 [details] [diff] [review]
dont-trace-browser

Review of attachment 789658 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/gc/RootMarking.cpp
@@ +752,3 @@
>      if (!rt->isHeapMinorCollecting()) {
>          /*
>           * All JSCompartment::mark does is mark the globals for compartements

Just noticed this--could you fix the spelling in "compartements"?

@@ +760,2 @@
>  
> +        /* The embedding can register additional roots here. */

Could you make a comment about why we don't need to mark these roots during minor GC? It looks like they're all in the store buffer. Nice job on all the Heap<> work!
Attachment #789658 - Flags: review?(wmccloskey) → review+
https://hg.mozilla.org/mozilla-central/rev/5d04a4f5ff6f
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in before you can comment on or make changes to this bug.