904674 - GC: Don't trace additional roots from the embedding on minor GC

Status: RESOLVED FIXED

Description

[Jon Coppeard (:jonco)]

Created attachment 789658 [details] [diff] [review]
dont-trace-browser

We don't want or need to trace the browser roots on a minor GC.

Comment 1

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 789658 [details] [diff] [review]
dont-trace-browser

Review of attachment 789658 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/gc/RootMarking.cpp
@@ +752,3 @@
>      if (!rt->isHeapMinorCollecting()) {
>          /*
>           * All JSCompartment::mark does is mark the globals for compartements

Just noticed this--could you fix the spelling in "compartements"?

@@ +760,2 @@
>  
> +        /* The embedding can register additional roots here. */

Could you make a comment about why we don't need to mark these roots during minor GC? It looks like they're all in the store buffer. Nice job on all the Heap<> work!

Comment 2

[Jon Coppeard (:jonco)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5d04a4f5ff6f

Comment 3

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/5d04a4f5ff6f