Closed
Bug 904689
Opened 12 years ago
Closed 12 years ago
Implement empty screen state for "Most Visited" page
Categories
(Firefox for Android Graveyard :: Awesomescreen, defect, P1)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 26
People
(Reporter: lucasr, Assigned: lucasr)
References
Details
(Whiteboard: [fixed-fig])
Attachments
(1 file)
|
15.90 KB,
patch
|
liuche
:
review+
|
Details | Diff | Splinter Review |
Same as the others.
|
Assignee | |
Updated•12 years ago
|
Assignee: nobody → lucasr.at.mozilla
|
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #790209 -
Flags: review?(liuche)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 790209 [details] [diff] [review]
Implement empty screen state for "Most Visited" page
Review of attachment 790209 [details] [diff] [review]:
-----------------------------------------------------------------
::: mobile/android/base/home/MostVisitedPage.java
@@ +91,5 @@
>
> @Override
> public void onViewCreated(View view, Bundle savedInstanceState) {
> + mTitle = (TextView) view.findViewById(R.id.title);
> + if (mTitle != null) {
Is this for tablet, where we might not have a title? I'll take note of that, for the other empty pages.
Attachment #790209 -
Flags: review?(liuche) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
(In reply to Chenxia Liu [:liuche] from comment #2)
> Comment on attachment 790209 [details] [diff] [review]
> Implement empty screen state for "Most Visited" page
>
> Review of attachment 790209 [details] [diff] [review]:
> -----------------------------------------------------------------
>
> ::: mobile/android/base/home/MostVisitedPage.java
> @@ +91,5 @@
> >
> > @Override
> > public void onViewCreated(View view, Bundle savedInstanceState) {
> > + mTitle = (TextView) view.findViewById(R.id.title);
> > + if (mTitle != null) {
>
> Is this for tablet, where we might not have a title? I'll take note of that,
> for the other empty pages.
Yep. Tablet UI doesn't have the title view.
|
|
Assignee | |
Comment 4•12 years ago
|
||
Whiteboard: [fixed-fig]
|
|
||
Comment 5•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 26
|
||
Updated•5 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•