904689 - Implement empty screen state for "Most Visited" page

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Awesomescreen, defect, P1)

Description

[Lucas Rocha (:lucasr)]

Same as the others.

Comment 1

[Lucas Rocha (:lucasr)]

Attachment: Implement empty screen state for "Most Visited" page

Comment 2

[Chenxia Liu [:liuche]]

Comment on attachment 790209 [details] [diff] [review]
Implement empty screen state for "Most Visited" page

Review of attachment 790209 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/home/MostVisitedPage.java
@@ +91,5 @@
>  
>      @Override
>      public void onViewCreated(View view, Bundle savedInstanceState) {
> +        mTitle = (TextView) view.findViewById(R.id.title);
> +        if (mTitle != null) {

Is this for tablet, where we might not have a title? I'll take note of that, for the other empty pages.

Comment 3

[Lucas Rocha (:lucasr)]

(In reply to Chenxia Liu [:liuche] from comment #2)
> Comment on attachment 790209 [details] [diff] [review]
> Implement empty screen state for "Most Visited" page
> 
> Review of attachment 790209 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: mobile/android/base/home/MostVisitedPage.java
> @@ +91,5 @@
> >  
> >      @Override
> >      public void onViewCreated(View view, Bundle savedInstanceState) {
> > +        mTitle = (TextView) view.findViewById(R.id.title);
> > +        if (mTitle != null) {
> 
> Is this for tablet, where we might not have a title? I'll take note of that,
> for the other empty pages.

Yep. Tablet UI doesn't have the title view.

Comment 4

[Lucas Rocha (:lucasr)]

Pushed: http://hg.mozilla.org/projects/fig/rev/7e1b879c9857

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/7e1b879c9857