904695 - Don't include nsReadableUtils.h in nsContentUtils.h

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Comment 1

[(no longer active)]

Attachment: Patch (v1)

The most pointless review request ever.  Does what it says on the can.  Whoever r+'es first wins!

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

You're still transitively including it.

Comment 3

[(no longer active)]

(In reply to comment #2)
> You're still transitively including it.

Through which header?

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

nsContentUtils.h -> nsContentListDeclarations.h -> nsStringGlue.h -> nsReadableUtils.h

Comment 5

[(no longer active)]

(In reply to comment #4)
> nsContentUtils.h -> nsContentListDeclarations.h -> nsStringGlue.h ->
> nsReadableUtils.h

Alright.

Comment 6

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 789679 [details] [diff] [review]
Patch (v1)

nsContentListDeclarations.h should be able to use nsStringFwd.h, I think.

Anyways as is the patch doesn't accomplish anything.

Comment 7

[(no longer active)]

Attachment: Patch (v2)

This does get the job done!

Comment 8

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 791415 [details] [diff] [review]
Patch (v2)

Review of attachment 791415 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/base/public/HTMLSplitOnSpacesTokenizer.h
@@ +3,5 @@
> + * License, v. 2.0. If a copy of the MPL was not distributed with this
> + * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
> +
> +#ifndef HTMLSplitOnSpacesTokenizer_h__
> +#define HTMLSplitOnSpacesTokenizer_h__

No trailing underscores per the style guide.

Comment 9

[(no longer active)]

(In reply to comment #8)
> Comment on attachment 791415 [details] [diff] [review]
>   --> https://bugzilla.mozilla.org/attachment.cgi?id=791415
> Patch (v2)
> 
> Review of attachment 791415 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: content/base/public/HTMLSplitOnSpacesTokenizer.h
> @@ +3,5 @@
> > + * License, v. 2.0. If a copy of the MPL was not distributed with this
> > + * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
> > +
> > +#ifndef HTMLSplitOnSpacesTokenizer_h__
> > +#define HTMLSplitOnSpacesTokenizer_h__
> 
> No trailing underscores per the style guide.

OK, this is the first time I'm hearing about this rule though, not sure why we have it...

Comment 10

[(no longer active)]

Attachment: Patch (v3)

Added the missing header, and addressed Ms2ger's nit.

Comment 11

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 791453 [details] [diff] [review]
Patch (v3)

I'm going to delegate this one to Ms2ger.

Comment 12

[(no longer active)]

Comment on attachment 791453 [details] [diff] [review]
Patch (v3)

Over to jst, since Ms2ger said he probably won't get to this before Friday, and I really don't want to spend time unbitrotting this again... :/

Comment 13

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/541ee3eb9d8b

Comment 14

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/541ee3eb9d8b