Don't include nsReadableUtils.h in nsContentUtils.h

RESOLVED FIXED in mozilla26

Status

()

defect
RESOLVED FIXED
6 years ago
5 months ago

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

(Blocks 1 bug)

Trunk
mozilla26
x86
macOS
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

No description provided.
Posted patch Patch (v1) (obsolete) — Splinter Review
The most pointless review request ever.  Does what it says on the can.  Whoever r+'es first wins!
Attachment #789679 - Flags: review?(khuey)
Attachment #789679 - Flags: review?(justin.lebar+bug)
Attachment #789679 - Flags: review?(Ms2ger)
You're still transitively including it.
(In reply to comment #2)
> You're still transitively including it.

Through which header?
nsContentUtils.h -> nsContentListDeclarations.h -> nsStringGlue.h -> nsReadableUtils.h
(In reply to comment #4)
> nsContentUtils.h -> nsContentListDeclarations.h -> nsStringGlue.h ->
> nsReadableUtils.h

Alright.
Comment on attachment 789679 [details] [diff] [review]
Patch (v1)

nsContentListDeclarations.h should be able to use nsStringFwd.h, I think.

Anyways as is the patch doesn't accomplish anything.
Attachment #789679 - Flags: review?(khuey)
Attachment #789679 - Flags: review?(justin.lebar+bug)
Attachment #789679 - Flags: review?(Ms2ger)
Posted patch Patch (v2) (obsolete) — Splinter Review
This does get the job done!
Attachment #789679 - Attachment is obsolete: true
Attachment #791415 - Flags: review?(khuey)
Comment on attachment 791415 [details] [diff] [review]
Patch (v2)

Review of attachment 791415 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/base/public/HTMLSplitOnSpacesTokenizer.h
@@ +3,5 @@
> + * License, v. 2.0. If a copy of the MPL was not distributed with this
> + * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
> +
> +#ifndef HTMLSplitOnSpacesTokenizer_h__
> +#define HTMLSplitOnSpacesTokenizer_h__

No trailing underscores per the style guide.
(In reply to comment #8)
> Comment on attachment 791415 [details] [diff] [review]
>   --> https://bugzilla.mozilla.org/attachment.cgi?id=791415
> Patch (v2)
> 
> Review of attachment 791415 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: content/base/public/HTMLSplitOnSpacesTokenizer.h
> @@ +3,5 @@
> > + * License, v. 2.0. If a copy of the MPL was not distributed with this
> > + * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
> > +
> > +#ifndef HTMLSplitOnSpacesTokenizer_h__
> > +#define HTMLSplitOnSpacesTokenizer_h__
> 
> No trailing underscores per the style guide.

OK, this is the first time I'm hearing about this rule though, not sure why we have it...
Posted patch Patch (v3)Splinter Review
Added the missing header, and addressed Ms2ger's nit.
Attachment #791415 - Attachment is obsolete: true
Attachment #791415 - Flags: review?(khuey)
Attachment #791453 - Flags: review?(khuey)
Comment on attachment 791453 [details] [diff] [review]
Patch (v3)

I'm going to delegate this one to Ms2ger.
Attachment #791453 - Flags: review?(khuey) → review?(Ms2ger)
Comment on attachment 791453 [details] [diff] [review]
Patch (v3)

Over to jst, since Ms2ger said he probably won't get to this before Friday, and I really don't want to spend time unbitrotting this again... :/
Attachment #791453 - Flags: review?(Ms2ger) → review?(jst)
Attachment #791453 - Flags: review?(jst) → review+
https://hg.mozilla.org/mozilla-central/rev/541ee3eb9d8b
Status: NEW → RESOLVED
Closed: 6 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.