Closed Bug 904703 Opened 10 years ago Closed 10 years ago
_l10n() helper should fallback to es-ES images for all es-* requests
In img_l10n() if we have an image for es-ES but not one for es-AR/CL/MX we display the en-US image as the fallback instead of the es-ES one. You can see that on the Firefox/os consumer page: Has localized screenshots: http://www.mozilla.org/es-ES/firefox/os/ Has English screenshots: http://www.mozilla.org/es-CL/firefox/os/ The rationale for es-ES as the arbitrary default is just that we already have screenshots in the es-ES folder. (Note that this is for img tags, on this same page the top screenshot is inserted via CSS, I have another fix for this one but I will file a separate bug as it is not a framework bug, just a css rule to adapt) I have a local patch that works and will do a pull request.
Pointer to Github pull-request
Commits pushed to master at https://github.com/mozilla/bedrock https://github.com/mozilla/bedrock/commit/8a5945a3ccb8185271dc1f7401723b8043fe4848 Bug 904703: Spanish locales fallback to es-ES for localized screenshots https://github.com/mozilla/bedrock/commit/172c0431c65ba29e9539a1248e5fabf681e35d86 Merge pull request #1188 from pmclanahan/Bug-904703_Spanishes_fallback_to_es-ES_images_for_screenshots Bug 904703: Spanish locales fallback to es-ES for localized screenshots
On dev, screenshots are not localized for Spanish in: /es-AR, /es-CL, /es-MX Ex: https://www-dev.allizom.org/es-AR/firefox/os/
all es-* images now fallback to es-ES except the first image next to the Haz que cada momento cuente will is still in English. https://www-dev.allizom.org/es-ES/firefox/os/ https://www-dev.allizom.org/es-MX/firefox/os/ https://www-dev.allizom.org/es-CL/firefox/os/
Commit pushed to master at https://github.com/mozilla/bedrock https://github.com/mozilla/bedrock/commit/9f4d9a62da0e2c023d78ba4b3fec6231850c4e11 Bug 904703: Firefox OS: fix first image for all Spanishes
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
verified fixed https://www.mozilla.org/es-ES/firefox/os/ https://www.mozilla.org/es-MX/firefox/os/ https://www.mozilla.org/es-CL/firefox/os/
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.