Last Comment Bug 904801 - update custom group coloring to include new -core-security groups
: update custom group coloring to include new -core-security groups
Status: RESOLVED FIXED
:
Product: bugzilla.mozilla.org
Classification: Other
Component: User Interface (show other bugs)
: Production
: All All
: -- normal (vote)
: ---
Assigned To: David Lawrence [:dkl]
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-08-13 12:48 PDT by Daniel Veditz [:dveditz]
Modified: 2013-08-14 07:31 PDT (History)
4 users (show)
See Also:
Due Date:
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
904801_1.patch (316 bytes, patch)
2013-08-13 14:24 PDT, David Lawrence [:dkl]
glob: review+
Details | Diff | Review

Description Daniel Veditz [:dveditz] 2013-08-13 12:48:28 PDT
Currently bugs with a bz_group that don't match a specific set of group names get a default color. The new core-security subgroups should get the same color as core-security instead

https://bugzilla.mozilla.org/skins/custom/bug_groups.css

We could either list them all individually, or create a matching rule

The current code is

  body.bz_group_core-security {
    background-color: #ffe0b0;
  }

And it could be either

  body[class*=core-security] {
    background-color: #ffe0b0;
  }

Or

  body.bz_group_b2g-core-security,
  body.bz_group_crypto-core-security,
  body.bz_group_dom-core-security,
  body.bz_group_firefox-core-security,
  body.bz_group_gfx-core-security,
  body.bz_group_javascript-core-security,
  body.bz_group_layout-core-security,
  body.bz_group_mail-core-security,
  body.bz_group_media-core-security,
  body.bz_group_network-core-security,
  body.bz_group_toolkit-core-security,
  body.bz_group_core-security {
    background-color: #ffe0b0;
  }

Will that one .css file cover it, or is this duplicated for each theme? If the latter please apply to those as well.
Comment 1 David Lawrence [:dkl] 2013-08-13 14:24:37 PDT
Created attachment 789818 [details] [diff] [review]
904801_1.patch

Looks good and works fine for my testing. Can't think of any reason this would be a bad thing to do but will run it by glob as well. Should work as well with the different skins since it is in the custom css dir.

dkl
Comment 2 Byron Jones ‹:glob› 2013-08-13 23:00:08 PDT
Comment on attachment 789818 [details] [diff] [review]
904801_1.patch

r=glob
Comment 3 David Lawrence [:dkl] 2013-08-14 07:31:36 PDT
Committing to: bzr+ssh://dlawrence%40mozilla.com@bzr.mozilla.org/bmo/4.2                
modified skins/custom/bug_groups.css
Committed revision 8941.

Note You need to log in before you can comment on or make changes to this bug.