update custom group coloring to include new -core-security groups

RESOLVED FIXED

Status

()

bugzilla.mozilla.org
User Interface
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: dveditz, Assigned: dkl)

Tracking

Production

Details

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
Currently bugs with a bz_group that don't match a specific set of group names get a default color. The new core-security subgroups should get the same color as core-security instead

https://bugzilla.mozilla.org/skins/custom/bug_groups.css

We could either list them all individually, or create a matching rule

The current code is

  body.bz_group_core-security {
    background-color: #ffe0b0;
  }

And it could be either

  body[class*=core-security] {
    background-color: #ffe0b0;
  }

Or

  body.bz_group_b2g-core-security,
  body.bz_group_crypto-core-security,
  body.bz_group_dom-core-security,
  body.bz_group_firefox-core-security,
  body.bz_group_gfx-core-security,
  body.bz_group_javascript-core-security,
  body.bz_group_layout-core-security,
  body.bz_group_mail-core-security,
  body.bz_group_media-core-security,
  body.bz_group_network-core-security,
  body.bz_group_toolkit-core-security,
  body.bz_group_core-security {
    background-color: #ffe0b0;
  }

Will that one .css file cover it, or is this duplicated for each theme? If the latter please apply to those as well.
(Assignee)

Comment 1

4 years ago
Created attachment 789818 [details] [diff] [review]
904801_1.patch

Looks good and works fine for my testing. Can't think of any reason this would be a bad thing to do but will run it by glob as well. Should work as well with the different skins since it is in the custom css dir.

dkl
Assignee: nobody → dkl
Status: NEW → ASSIGNED
Attachment #789818 - Flags: review?(glob)
Comment on attachment 789818 [details] [diff] [review]
904801_1.patch

r=glob
Attachment #789818 - Flags: review?(glob) → review+
(Assignee)

Comment 3

4 years ago
Committing to: bzr+ssh://dlawrence%40mozilla.com@bzr.mozilla.org/bmo/4.2                
modified skins/custom/bug_groups.css
Committed revision 8941.
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
OS: Windows 7 → All
Hardware: x86_64 → All
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.