904862 - [traceback] 500 Error: ValueError: invalid literal for int() with base 10: '20"'

Status: VERIFIED FIXED

(Participation Infrastructure :: Phonebook, defect)

Description

[Matt Brandt [:mbrandt]]

Steps to reproduce
0. goto https://mozillians.org/search/?limit=20%22;%20waitfor%20delay%20%270:0:7.55%27%20--%20&page=21&q

Acutal:
Traceback (most recent call last):

  File "/data/www/mozillians.org/mozillians/vendor/src/django/django/core/handlers/base.py", line 111, in get_response
    response = callback(request, *callback_args, **callback_kwargs)

  File "/usr/lib64/python2.6/site-packages/newrelic-1.10.2.38/newrelic/api/object_wrapper.py", line 220, in __call__
    self._nr_instance, args, kwargs)

  File "/usr/lib64/python2.6/site-packages/newrelic-1.10.2.38/newrelic/hooks/framework_django.py", line 475, in wrapper
    return wrapped(*args, **kwargs)

  File "/data/www/mozillians.org/mozillians/apps/phonebook/views.py", line 190, in search
    if form.is_valid():

  File "/data/www/mozillians.org/mozillians/vendor/src/django/django/forms/forms.py", line 124, in is_valid
    return self.is_bound and not bool(self.errors)

  File "/data/www/mozillians.org/mozillians/vendor/src/django/django/forms/forms.py", line 115, in _get_errors
    self.full_clean()

  File "/data/www/mozillians.org/mozillians/vendor/src/django/django/forms/forms.py", line 270, in full_clean
    self._clean_fields()

  File "/data/www/mozillians.org/mozillians/vendor/src/happyforms/happyforms/__init__.py", line 32, in _clean_fields
    value = getattr(self, 'clean_%s' % name)()

  File "/data/www/mozillians.org/mozillians/apps/phonebook/forms.py", line 36, in clean_limit
    elif not REGEX_NUMERIC.match(str(limit)) or int(limit) < 1:

ValueError: invalid literal for int() with base 10: '20"'

Comment 1

[Giorgos Logiotatidis [:giorgos]]

For some reason googlebot hits this url often. It should be fixed anyway, but fortunately it's not a real person who gets the error.

Thanks for reporting Matt!

Comment 2

[Matt Brandt [:mbrandt]]

That darn googlebot ;) thanks for looking it this Giorgos

Comment 3

[[github robot]]

Commits pushed to master at https://github.com/mozilla/mozillians

https://github.com/mozilla/mozillians/commit/60b5957445ae67f8aebcaa21fe63f8fc19fdaae2
[fix bug 904862] Use IntegerField in SearchForm.

- Use IntegerField in SearchForm.
- Update HTML of Search.

https://github.com/mozilla/mozillians/commit/2113f509c742d4c27180eb72c72d6f864646f1b3
Merge pull request #584 from glogiotatidis/904826

[fix bug 904862] Use IntegerField in SearchForm.

Comment 4

[Matt Brandt [:mbrandt]]

Attachment: qa - verified on stage

QA verified on stage - the googlebot has been tamed :)

https://mozillians.allizom.org/en-US/search/?limit=20%22;%20waitfor%20delay%20%270:0:7.55%27%20--%20&page=21&q