904864 - Defect - Richgrid does not account for space needed during touch selection down swipes

Status: RESOLVED INCOMPLETE

(Firefox for Metro Graveyard :: Components, defect)

Description

[Jonathan Wilde [:jwilde]]

If the height of the richgrid is calculated to be relatively small (as in bug 904417), then there isn't enough space left over for the tiles on the bottom row when they are swiped down. Because of this, as you swipe down, they get clipped at the bottom of the richgrid container. When you release the tile, a scrollbar momentarily appears and the tile bounced back up.

Comment 1

[Sam Foster [:sfoster] (he/him)]

Ideally we want the tiles to be z-indexed so they can be dragged outside the richgrid container. Probably adding some padding is the quick fix, but bear in mind cross-slide can be a swipe up as well as down for horizontally-aligned grids. So, while bottom padding wont hurt, top-padding will; we may need to revisit this is people are swiping up and running into the same issue.

Comment 2

[Jonathan Wilde [:jwilde]]

Braindump:

Just adding padding to the bottom is going to make the portrait mode paddings a little weird.

Another temporary workaround is to do overflow: hidden on the grid, but that causes clipping on cross slide.

We could work around that, but I suspect that doing a version of the z-index idea would be the best plan. Suggested implementation: have some sort of wrapper around richgriditem (or, based on the current impl, just use richgriditem as the wrapper and manipulate .tile-content, but this is a little unclean). Make sure the wrapper takes up a full tile size without anything in it, and isn't position: relative/absolute. When doing crossslide, apply position: absolute to the tile content element, align top and left against the wrapper's position, and then use transforms as normal. Then add that little checkmark from the W8 start screen tiles as a background on the wrapper for polish, and we should be all set. :D

Comment 3

[Jonathan Wilde [:jwilde]]

Attachment: wallpaper - overflow: hidden

Comment 4

[Firefox Bug Husbandry Bot]

Mass close of bugs in obsolete product https://bugzilla.mozilla.org/show_bug.cgi?id=1350354