904889 - [Australis][Win7][hidpi] In >100%dpi, closing tab when tabbar is overflowing causes the end arrow to flicker

Status: RESOLVED WORKSFORME

(Firefox :: Theme, defect)

Description

[Marco Castelluccio [:marco]]

Closing a tab (when you have many tabs opened) causes the overflow arrow button to flash (enabled -> disabled -> enabled -> disabled).
This doesn't happen always, but is easily reproducible.

Comment 1

[Matthew N. [:MattN]]

Hmm… this sounds like what I reported as #2 in bug 813802 comment 107. Perhaps we have regressed that.

Comment 2

[:Gijs (he/him)]

If we hit the overflow case here, I suspect this hits our tab perf as well.

Comment 3

[:Gijs (he/him)]

(In reply to Marco Castelluccio [:marco] from comment #3)
> Closing a tab (when you have many tabs opened) causes the overflow arrow
> button to flash (enabled -> disabled -> enabled -> disabled).
> This doesn't happen always, but is easily reproducible.

Marco, do you know if this is Windows-only?

Comment 4

[:Gijs (he/him)]

I can't reproduce this on either Win7 or OS X. :-(

Comment 5

[:Gijs (he/him)]

(In reply to :Gijs Kruitbosch from comment #4)
> I can't reproduce this on either Win7 or OS X. :-(

... which might mean this was fixed by bug 908796 landing?

Comment 6

[Marco Castelluccio [:marco]]

(In reply to :Gijs Kruitbosch from comment #3)
> (In reply to Marco Castelluccio [:marco] from comment #3)
> > Closing a tab (when you have many tabs opened) causes the overflow arrow
> > button to flash (enabled -> disabled -> enabled -> disabled).
> > This doesn't happen always, but is easily reproducible.
> 
> Marco, do you know if this is Windows-only?

I can't reproduce on Linux. I'll try again on Windows later.

Comment 7

[Matthew N. [:MattN]]

=> WFM for now

Comment 8

[Marco Castelluccio [:marco]]

It doesn't always happen, but I can still reproduce on Windows.

Comment 9

[Marco Castelluccio [:marco]]

I think the difference between Windows and Linux that causes this bug is that on Windows the overflow button is activated when I open a new tab.
The rightmost part of the tab is hidden behind the overflow button and I can click the button to show the remaining part of the tab.

Comment 10

[Marco Castelluccio [:marco]]

Attachment: How it is

Comment 11

[Marco Castelluccio [:marco]]

Attachment: How it should be

At least, this is how it is on Linux.

Comment 12

[:Gijs (he/him)]

I suspect this is fixed by bug 875180. Marco, can you verify this on tomorrow's (Oct. 23) nightly?

Comment 13

[:Gijs (he/him)]

This seems to be fixed on Windows, indeed.

Comment 14

[Marco Castelluccio [:marco]]

I can't reproduce the problem of the screenshot, the tabs aren't opened halfway anymore.
But I can still reproduce the button flashing.

Comment 15

[:Gijs (he/him)]

(In reply to Marco Castelluccio [:marco] from comment #14)
> I can't reproduce the problem of the screenshot, the tabs aren't opened
> halfway anymore.
> But I can still reproduce the button flashing.

You mean it's on briefly as the new tab goes into view, and then is disabled again? That happens on Nightly too...

Comment 16

[Marco Castelluccio [:marco]]

(In reply to :Gijs Kruitbosch from comment #15)
> (In reply to Marco Castelluccio [:marco] from comment #14)
> > I can't reproduce the problem of the screenshot, the tabs aren't opened
> > halfway anymore.
> > But I can still reproduce the button flashing.
> 
> You mean it's on briefly as the new tab goes into view, and then is disabled
> again? That happens on Nightly too...

When you close a tab, the arrow button goes from enabled to disabled and from disabled to enabled several times.
On Nightly the button is never enabled.

(I'm talking about closing a tab, not opening)

Comment 17

[:Gijs (he/him)]

(In reply to Marco Castelluccio [:marco] from comment #16)
> (In reply to :Gijs Kruitbosch from comment #15)
> > (In reply to Marco Castelluccio [:marco] from comment #14)
> > > I can't reproduce the problem of the screenshot, the tabs aren't opened
> > > halfway anymore.
> > > But I can still reproduce the button flashing.
> > 
> > You mean it's on briefly as the new tab goes into view, and then is disabled
> > again? That happens on Nightly too...
> 
> When you close a tab, the arrow button goes from enabled to disabled and
> from disabled to enabled several times.
> On Nightly the button is never enabled.
> 
> (I'm talking about closing a tab, not opening)

Comment 9 was about opening a tab... In any case, I can't reproduce this on Windows. Are you using Firefox in restored, maximized or fullscreen? What theme are you using? What version of Windows? And you're on either today's or yesterday's nightly?

Comment 18

[Marco Castelluccio [:marco]]

Attachment: test.avi

(In reply to :Gijs Kruitbosch from comment #17)
> Comment 9 was about opening a tab... In any case, I can't reproduce this on
> Windows. Are you using Firefox in restored, maximized or fullscreen? What
> theme are you using? What version of Windows? And you're on either today's
> or yesterday's nightly?

Yes, the problem in comment 9 is fixed now.
I'm using Firefox in maximized mode, default theme, Windows 7, today's nightly.

Comment 19

[Marco Castelluccio [:marco]]

I can't reproduce on my second machine. Maybe it's the different resolution? The first machine has a high-resolution display.

Comment 20

[:Gijs (he/him)]

(In reply to Marco Castelluccio [:marco] from comment #19)
> I can't reproduce on my second machine. Maybe it's the different resolution?
> The first machine has a high-resolution display.

Can you reproduce on the first machine with a clean profile?

Comment 21

[:Gijs (he/him)]

(In reply to :Gijs Kruitbosch from comment #20)
> (In reply to Marco Castelluccio [:marco] from comment #19)
> > I can't reproduce on my second machine. Maybe it's the different resolution?
> > The first machine has a high-resolution display.
> 
> Can you reproduce on the first machine with a clean profile?

Ah, nevermind. Updated STR:


1. Set font size in the "Display" part of the Win7 preferences to 125%
2. Log off and back on
3. Open enough tabs to overflow
4. Close the last tab

Comment 22

[Justin Dolske [:Dolske]]

Given that the difference between the two arrow states is kind of subtle, I think that will make the flickering less noticeable/janky than it otherwise might be (although I didn't actually test this on Windows!)

The arrows end up in the right state at the end, right?