904891 - Missing subtier definition of XPIDLParser for mach

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

See upcoming patch. Incidentally, this breaks the patch from bug 883209.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Missing subtier definition of XPIDLParser for mach

Comment 2

[Gregory Szorc [:gps]]

Comment on attachment 789865 [details] [diff] [review]
Missing subtier definition of XPIDLParser for mach

Review of attachment 789865 [details] [diff] [review]:
-----------------------------------------------------------------

I'm tempted to WONTFIX this. I don't think this build action warrants pixels on the screen. Furthermore, I thought I folded it into the xpidl subtier in bug 850380.

Comment 3

[Mike Hommey [:glandium]]

(In reply to Gregory Szorc [:gps] from comment #2)
> Furthermore, I thought I folded it into the xpidl subtier in
> bug 850380.

It's not folded:
https://hg.mozilla.org/integration/mozilla-inbound/diff/13f3b8949f63/config/makefiles/precompile/Makefile.in

Comment 4

[Gregory Szorc [:gps]]

Comment on attachment 789865 [details] [diff] [review]
Missing subtier definition of XPIDLParser for mach

Review of attachment 789865 [details] [diff] [review]:
-----------------------------------------------------------------

Feel free to commit this. It'll likely get folded into the xpidl subtier in some subsequent patch though. I suppose you could do that here...

Comment 5

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9b662feee9f7

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/9b662feee9f7