Closed
Bug 904929
Opened 11 years ago
Closed 11 years ago
Task.jsm: exceptions handled differently if the argument is a regular function
Categories
(Toolkit :: General, defect)
Toolkit
General
Tracking
()
RESOLVED
FIXED
mozilla26
People
(Reporter: marco, Assigned: marco)
References
Details
(Whiteboard: [Async])
Attachments
(1 file, 1 obsolete file)
2.61 KB,
patch
|
Paolo
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #789935 -
Flags: review?(dteller)
Comment 2•11 years ago
|
||
Comment on attachment 789935 [details] [diff] [review] taskjsm_exceptions Review of attachment 789935 [details] [diff] [review]: ----------------------------------------------------------------- This looks good to me, but Paolo is a better person to review this patch.
Attachment #789935 -
Flags: review?(paolo.mozmail)
Attachment #789935 -
Flags: review?(dteller)
Attachment #789935 -
Flags: feedback+
Updated•11 years ago
|
Whiteboard: [Async]
Comment 3•11 years ago
|
||
Comment on attachment 789935 [details] [diff] [review] taskjsm_exceptions Looks good! This is a superset of bug 899214 and the right thing to do. It just needs two new xpcshell test cases for the two types of exception, and then we're ready to go.
Attachment #789935 -
Flags: review?(paolo.mozmail) → feedback+
Assignee | ||
Comment 5•11 years ago
|
||
Are there any other tests needed?
Assignee: nobody → mcastelluccio
Attachment #789935 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #790522 -
Flags: review?(paolo.mozmail)
Comment 6•11 years ago
|
||
Comment on attachment 790522 [details] [diff] [review] taskjsm_exceptions (In reply to Marco Castelluccio [:marco] from comment #5) > Are there any other tests needed? This is all that comes to my mind. If none of the automated tests are broken by this possible change in behavior, this is ready to land. Grazie mille! :-)
Attachment #790522 -
Flags: review?(paolo.mozmail) → review+
Assignee | ||
Comment 7•11 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=dc7d9ac72b3e
Keywords: checkin-needed
Comment 8•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/307c8dc8c86b
Keywords: checkin-needed
Comment 9•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/307c8dc8c86b
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in
before you can comment on or make changes to this bug.
Description
•