904929 - Task.jsm: exceptions handled differently if the argument is a regular function

Status: RESOLVED FIXED

(Toolkit :: General, defect)

Comment 1

[Marco Castelluccio [:marco]]

Attachment: taskjsm_exceptions

Comment 2

[David Teller [:Yoric] - still alive but not very active]

Comment on attachment 789935 [details] [diff] [review]
taskjsm_exceptions

Review of attachment 789935 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good to me, but Paolo is a better person to review this patch.

Comment 3

[:Paolo Amadini]

Comment on attachment 789935 [details] [diff] [review]
taskjsm_exceptions

Looks good! This is a superset of bug 899214 and the right thing to do. It
just needs two new xpcshell test cases for the two types of exception, and
then we're ready to go.

Comment 5

[Marco Castelluccio [:marco]]

Attachment: taskjsm_exceptions

Are there any other tests needed?

Comment 6

[:Paolo Amadini]

Comment on attachment 790522 [details] [diff] [review]
taskjsm_exceptions

(In reply to Marco Castelluccio [:marco] from comment #5)
> Are there any other tests needed?

This is all that comes to my mind. If none of the automated tests are broken by
this possible change in behavior, this is ready to land. Grazie mille! :-)

Comment 7

[Marco Castelluccio [:marco]]

https://tbpl.mozilla.org/?tree=Try&rev=dc7d9ac72b3e

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/307c8dc8c86b

Comment 9

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/307c8dc8c86b