904998 - Export "close" button icon for autocomplete.

Status: VERIFIED FIXED

(Firefox for Metro Graveyard :: Browser, defect, P1)

Description

[Kamil Jozwiak [:kjozwiak]]

Attachment: Close "X" button is really hard to see

I think it would be a good idea to make the "X" button under the "Your Results" & "Search For" screen a lot darker as its currently really hard to see as the background color is almost the same shade as the button. Maybe make it as dark as the buttons under the "Navigation App Bar" so it matches the theme?

- Attached a screenshot to illustrate the issue

Yuan, your thoughts?

Steps to reproduce the issue:

1) Open Firefox Metro
2) Tap on the text box in the Navigation App Bar and start typing something (Should see the "Your Results" & "Search For" screen)
3) At the bottom right corner, you should see the "X" button (really hard to see)

Current Behavior:

- The close "X" button is almost the same color as the background making it very difficult to see

Expected Behavior:

- Button should be a bit darker so its a lot easier to see

Used the following build:
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-08-13-03-02-05-mozilla-central/

Comment 1

[Yuan Wang(:Yuan) – Mobile Firefox Design Lead]

I am aware of this. Thanks, Kamil.

Currently there are a few bugs awaiting assets from our visual designer. This is one of them. 

The icon supposed to be grey not white. See this screenshot: http://cl.ly/image/442R3F2p3V3D

Comment 2

[Jonathan Wilde [:jwilde]]

I can't seem to find the bug I thought I filed about getting a an icon slice, so morphing this and assigning to shorlander.

shorlander, can we get sprites at 100%, 140%, and 180% for the close icon in https://bug895520.bugzilla.mozilla.org/attachment.cgi?id=785773? Thanks!

Comment 3

[Marco Mucci [:MarcoM]]

Hey Stephen, do you know when you can provide the "close" button icon for autocomplete?

Comment 4

[Yuan Wang(:Yuan) – Mobile Firefox Design Lead]

Attachment: [e-mail]

Comment 5

[Yuan Wang(:Yuan) – Mobile Firefox Design Lead]

Attachment: icon-close.png

Comment 6

[Manuela Muntean [Away]]

Attachment: no_close_button.png

With the latest Nightly 29.0a1 (build ID: 20131218030217) on Win 8 64-bit, I can't see at all any "close" button icon for the autocomplete screen. Please see the attached screenshot for details.

Should I file a new bug for this issue?

Comment 7

[Jim Mathies [:jimm]]

(In reply to Manuela Muntean [:Manuela] [QA] from comment #6)
> Created attachment 8350015 [details]
> no_close_button.png
> 
> With the latest Nightly 29.0a1 (build ID: 20131218030217) on Win 8 64-bit, I
> can't see at all any "close" button icon for the autocomplete screen. Please
> see the attached screenshot for details.
> 
> Should I file a new bug for this issue?

Yes, dependent on this one. I think this bug was about getting the button graphics from design. We currently don't have a bug filed on integrating the button into the ui.

Comment 8

[Michael Maslaney [:mmaslaney] ([e-mail])]

Attachment: icon-navBar-close.zip

Updated Close button.

Comment 9

[Manuela Muntean [Away]]

Thank you Jim! I've logged bug  952906 accordingly.

Comment 10

[Matt Brubeck (:mbrubeck)]

Marking "status-firefox28: fixed" to get this design-only bug off our Fx28 uplift radar.

Comment 11

[u279076]

Kamil, please verify this is fixed in the latest Firefox Nightly and Aurora builds.

Comment 12

[Kamil Jozwiak [:kjozwiak]]

Went through the following issue for iteration #21 without any issues. Used the following builds:
- http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014-01-16-03-02-50-mozilla-central/

Going through this issue alongside with Bug # 952906.

- Went through the original test case from comment #0 without any issues
- Ensured that the "X" is visible when viewing the Search App Bar under about:start
- Ensured that the "X" is visible when viewing the Search App Bar under several other websites
- Ensured that the "X" hover status doesn't get stuck when taping/clicking on it
- Ensured that the "X" button is using anti-aliasing (smooth, clear without any rough edges.
- Ensured that all of the above test cases worked in both full and filled views (using a variety of different screen widths)

Checked today's Aurora build and the changes still haven't made it in, will take a look tomorrow to complete verification. Leaving needinfo until both channels have been verified.

Comment 13

[Kamil Jozwiak [:kjozwiak]]

Went through the following defect for iteration #21 without any issues. Used the following build:
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014-01-17-00-40-24-mozilla-aurora/

- Went through the original test case from comment #0 without any issues
- Went through all the test cases from comment #12 without any issues
- Also went through Bug # 952906 alongside this one