Closed Bug 905107 Opened 6 years ago Closed 6 years ago
B2G Emulator: add test cases for REQUEST
409 bytes, text/html
1.42 KB, patch
|Details | Diff | Splinter Review|
1.77 KB, patch
|Details | Diff | Splinter Review|
406 bytes, text/html
Bug 899885 left a typo on sending "setScreenState" worker message and was fixed in bug 905090. We currently have no marionette test cases for this request because neither hardware/ril nor external/qemu is capable of handling it. A xpcshel test case here won't really help because we may still have similar mistakes in other places. The purpose of REQUEST_SCREEN_STATE can be found in ril.h: When the screen is off, the RIL should notify the baseband to suppress certain notifications (eg, signal strength and changes in LAC/CID or BID/SID/NID/latitude/longitude) in an effort to conserve power. These notifications should resume when the screen is on. Related AT commands could be: 1. 3GPP 27.007 subclause 7.2 "Network registration +CREG" 2. 3GPP 27.007 subclause 8.10 "Mobile termination event reporting +CMER" 3. 3GPP 27.007 subclause 8.41 "Time zone reporting +CTZR" 4. 3GPP 27.007 subclause 8.50 "Mobile originated location request +CMOLR" 5. 3GPP 27.007 subclause 8.56 "Positioning reporting +CPOSR" 6. 3GPP 27.007 subclause 8.59 "Battery capacity +CBCAP" 7. 3GPP 27.007 subclause 8.60 "Battery connection status +CBCON" 8. 3GPP 27.007 subclause 8.61 "Battery charger status +CBCHG" ... We're most likely to use "+CREG=1" for screen off and "+CREG=2" for screen on. : https://github.com/mozilla-b2g/platform_hardware_ril/blob/master/include/telephony/ril.h#L2330
I created a patch for the reference RIL to send AT+CREG when it receives REQUEST_SCREEN_STATE. I'm not sure how to test this, though. Is there a way for retrieving the network state?
Attachment #793506 - Flags: feedback?(vyang)
Assignee: nobody → tzimmermann
Status: NEW → ASSIGNED
Comment on attachment 793506 [details] Github pull request Then we need a patch to qemu, revealing current |modem->voice_mode| to determine whether we're in A_REGISTRATION_UNSOL_ENABLED or A_REGISTRATION_UNSOL_ENABLED_FULL state. I suggest a "gsm report [type1[,type2[,..]]] [on,off]" console command for this. gsm report - print the statuses of all supported types. gsm report creg - print creg verbose reporting status only gsm report creg on - turn on creg verbose reporting gsm report creg off - turn off creg verbose reporting Also need to ensure that ril_worker accepts CREG without cell info. But since hardware/ril returns (-1, -1) in this case, I think it will be fine. : https://github.com/mozilla-b2g/platform_external_qemu/blob/master/telephony/android_modem.c#L1640 : http://mxr.mozilla.org/mozilla-central/source/dom/system/gonk/ril_worker.js#3730 : https://github.com/mozilla-b2g/platform_hardware_ril/blob/master/reference-ril/reference-ril.c#L1234
Attachment #793506 - Flags: feedback?(vyang) → feedback+
(In reply to Vicamo Yang [:vicamo][:vyang] from comment #2) > gsm report creg on - turn on creg verbose reporting > gsm report creg off - turn off creg verbose reporting The ability to enable/disable reporting is not necessary for this bug.
This fixes a bug in the RIL worker.
Attachment #814409 - Flags: review?(vyang)
Sorry that it took me so long to update this bug. I was distracted by NFC.
Comment on attachment 814409 [details] [diff] [review]  Bug 905107: Fix options in RIL.setScreenState Review of attachment 814409 [details] [diff] [review]: ----------------------------------------------------------------- r=me, thank you :)
Attachment #814409 - Flags: review?(vyang) → review+
Attachment #814410 - Flags: review?(vyang) → review+
Comment on attachment 814406 [details] Github pull request for QEmu `modem->voice_mode` is a ARegistrationUnsolMode-typed variable, not ARegistrationState. Please move the definition of ARegistrationUnsolMode from telephony/android_modem.c to telephony/android_modem.h and return correct type here. Besides, function name `amodem_get_voice_unsol_mode` is more preferable for me because there is also a data member called `data_mode` in AModemRec structure.
Comment on attachment 814407 [details] Github pull request for RIL `at_response_free(p_response);` missed.
Comment on attachment 814406 [details] Github pull request for QEmu I updated the patch according to your review.
A new pull request for the RIL with the changes you requested.
Attachment #814406 - Flags: review?(vyang) → review+
Attachment #814841 - Flags: review?(vyang) → review+
Merged on GitHub: @master: https://github.com/mozilla-b2g/platform_external_qemu/commit/48c7ad40691f0aff78d9ce127f1f7f82cb7e62de https://github.com/mozilla-b2g/platform_hardware_ril/commit/eda08beb3ba9a159843c70ffde0f9660ec351eb9 @b2g-jellybean: https://github.com/mozilla-b2g/platform_external_qemu/commit/fd2726ada035d814b1b4f823625a003d2bef3620 https://github.com/mozilla-b2g/platform_hardware_ril/commit/2838a77ce4b8c09fa6a46fe25410bb3a4474cbd4
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.