905161 - GLContext cache features

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Guillaume Abadie]

Cache GLContext features to let use a OpenGL context even some features theoretically natively supported are missing.

Comment 1

[Guillaume Abadie]

Attachment: patch step 1 - revision 1: Cache GLFeatures

Comment 2

[Guillaume Abadie]

Attachment: patch step 2 - revision 1: Remove the GLContext::MarkUnsupported's return type

Comment 3

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 794694 [details] [diff] [review]
patch step 1 - revision 1: Cache GLFeatures

Review of attachment 794694 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/gl/GLContext.cpp
@@ +469,5 @@
>                  }
>              }
>          }
>  
> +        InitFeatures();

Don't we want to do this immediately after InitExtensions?

Comment 4

[Guillaume Abadie]

(In reply to Jeff Gilbert [:jgilbert] from comment #3)
> Comment on attachment 794694 [details] [diff] [review]
> patch step 1 - revision 1: Cache GLFeatures
> 
> Review of attachment 794694 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: gfx/gl/GLContext.cpp
> @@ +469,5 @@
> >                  }
> >              }
> >          }
> >  
> > +        InitFeatures();
> 
> Don't we want to do this immediately after InitExtensions?
No because after the extensions initialization, we are checking especially for {ARB,EXT}_robustness. Therefore, InitFeatures() come write after. =)

Comment 5

[Guillaume Abadie]

right after* =D

Comment 6

[Guillaume Abadie]

Attachment: patch step 1 - revision 2: Cache GLFeatures

Comment 7

[Guillaume Abadie]

Attachment: patch step 1 - revision for landing

As discussed offline, here are fixes.

Comment 8

[Guillaume Abadie]

Thanks!
https://hg.mozilla.org/integration/mozilla-inbound/rev/49619e60f765
https://hg.mozilla.org/integration/mozilla-inbound/rev/ba24673040d6

Comment 9

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/49619e60f765
https://hg.mozilla.org/mozilla-central/rev/ba24673040d6