Closed Bug 905161 Opened 7 years ago Closed 7 years ago

GLContext cache features

Categories

(Core :: Graphics, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla26

People

(Reporter: guillaume.abadie, Assigned: guillaume.abadie)

References

Details

Attachments

(2 files, 2 obsolete files)

Cache GLContext features to let use a OpenGL context even some features theoretically natively supported are missing.
Blocks: 899855
Attachment #794694 - Flags: review?(jgilbert)
Attachment #794695 - Flags: review?(jgilbert) → review+
Comment on attachment 794694 [details] [diff] [review]
patch step 1 - revision 1: Cache GLFeatures

Review of attachment 794694 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/gl/GLContext.cpp
@@ +469,5 @@
>                  }
>              }
>          }
>  
> +        InitFeatures();

Don't we want to do this immediately after InitExtensions?
(In reply to Jeff Gilbert [:jgilbert] from comment #3)
> Comment on attachment 794694 [details] [diff] [review]
> patch step 1 - revision 1: Cache GLFeatures
> 
> Review of attachment 794694 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: gfx/gl/GLContext.cpp
> @@ +469,5 @@
> >                  }
> >              }
> >          }
> >  
> > +        InitFeatures();
> 
> Don't we want to do this immediately after InitExtensions?
No because after the extensions initialization, we are checking especially for {ARB,EXT}_robustness. Therefore, InitFeatures() come write after. =)
right after* =D
Attachment #794694 - Attachment is obsolete: true
Attachment #794694 - Flags: review?(jgilbert)
Attachment #794905 - Flags: review?(jgilbert)
As discussed offline, here are fixes.
Attachment #794905 - Attachment is obsolete: true
Attachment #794905 - Flags: review?(jgilbert)
Attachment #794922 - Flags: review?(jgilbert)
Attachment #794922 - Flags: review?(jgilbert) → review+
https://hg.mozilla.org/mozilla-central/rev/49619e60f765
https://hg.mozilla.org/mozilla-central/rev/ba24673040d6
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in before you can comment on or make changes to this bug.