Closed Bug 905189 Opened 12 years ago Closed 12 years ago

Tag the production branch of mozharness for releases

Categories

(Release Engineering :: Applications: MozharnessCore, defect, P2)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: armenzg, Assigned: rail)

Details

Attachments

(1 file, 1 obsolete file)

We currently tag the "default" branch which can be misleading.
We do tag the production tag (actually we treat it as revision: hg tag -r production), but the tagging commits go to the default branch. This is applicable to other repos listed in otherReposToTag (buildbot, compare-locales and partner-repacks). We should update the repos to the desired revision before we do tagging. Patch incoming.
Assignee: nobody → rail
OS: Mac OS X → All
Priority: -- → P2
Hardware: x86 → All
Attached patch update to revision first (obsolete) — Splinter Review
Attachment #790259 - Flags: review?(bhearsum)
Comment on attachment 790259 [details] [diff] [review] update to revision first Review of attachment 790259 [details] [diff] [review]: ----------------------------------------------------------------- To be clear: we're already tagging the correct revision, we're just doing it on the wrong branch -- right?
Attachment #790259 - Flags: review?(bhearsum) → review+
(In reply to Ben Hearsum [:bhearsum] from comment #3) > To be clear: we're already tagging the correct revision, we're just doing it > on the wrong branch -- right? Correct.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Tagging of compare-locales failed because update(repo, revision=revision) doesn't update to the tip of the current branch and tag() creates a new head.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attachment #790259 - Flags: checked-in+ → checked-in-
Attached patch update twiceSplinter Review
To be tested.
Attachment #790259 - Attachment is obsolete: true
Comment on attachment 791397 [details] [diff] [review] update twice Worked fine in staging. I rerun TB 24.0b2 tagging against the same repos and got this: http://people.mozilla.org/~raliiev/sattap/a34b2869.png corresponding log snippet: retry: Calling <function mercurial at 0x18e0b90> with args: ('https://hg.mozilla.org/users/raliiev_mozilla.com/mozharness', 'mozharness'), kwargs: {}, attempt #1 Reporting hg version in use command: START command: hg -q version command: cwd: . command: output: Mercurial Distributed SCM (version 2.5.4) command: END (0.25s elapsed) Checking if share extension works command: START command: hg help share command: cwd: /builds/slave/rel-c-beta-tb_tag-000000000000 command: END (0.22 elapsed) Updating shared repo Reporting hg version in use command: START command: hg -q version command: cwd: . command: output: Mercurial Distributed SCM (version 2.5.4) command: END (0.20s elapsed) command: START command: hg clone -U https://hg.mozilla.org/users/raliiev_mozilla.com/mozharness /builds/hg-shared/users/raliiev_mozilla.com/mozharness command: cwd: /builds/slave/rel-c-beta-tb_tag-000000000000 command: output: warning: hg.mozilla.org certificate with fingerprint 10:78:e8:57:2d:95:de:7c:de:90:bd:22:e1:38:17:67:c5:a7:9c:14 not verified (check hostfingerprints or web.cacerts config setting) requesting all changes adding changesets adding manifests adding file changes added 1793 changesets with 3220 changes to 330 files (+1 heads) command: END (2.21s elapsed) Trying to share /builds/hg-shared/users/raliiev_mozilla.com/mozharness to /builds/slave/rel-c-beta-tb_tag-000000000000/mozharness command: START command: hg share -U /builds/hg-shared/users/raliiev_mozilla.com/mozharness /builds/slave/rel-c-beta-tb_tag-000000000000/mozharness command: cwd: /builds/slave/rel-c-beta-tb_tag-000000000000 command: output: command: END (0.27s elapsed) command: START command: hg branch command: cwd: /builds/slave/rel-c-beta-tb_tag-000000000000/mozharness command: output: default command: END (0.22 elapsed) command: START command: hg update -C command: cwd: /builds/slave/rel-c-beta-tb_tag-000000000000/mozharness command: output: 176 files updated, 0 files merged, 0 files removed, 0 files unresolved command: END (0.42s elapsed) command: START command: hg parent --template {node|short} command: cwd: /builds/slave/rel-c-beta-tb_tag-000000000000/mozharness command: output: 875304dfb74b command: END (0.25 elapsed) retry: Calling <function apply_and_push at 0x18e0c08> with args: ('mozharness', 'ssh://hg.mozilla.org/users/raliiev_mozilla.com/mozharness', <function tag_wrapper at 0x194bcf8>, 10), kwargs: {'ssh_username': 'stage-ffxbld', 'ssh_key': '/home/mock_mozilla/.ssh/ffxbld_dsa'}, attempt #1 command: START command: hg branch command: cwd: mozharness command: output: default command: END (0.22 elapsed) command: START command: hg update -C -r production command: cwd: mozharness command: output: 58 files updated, 0 files merged, 14 files removed, 0 files unresolved command: END (0.37s elapsed) command: START command: hg parent --template {node|short} command: cwd: mozharness command: output: fea220075a82 command: END (1.17 elapsed) command: START command: hg branch command: cwd: mozharness command: output: production command: END (0.25 elapsed) command: START command: hg update -C command: cwd: mozharness command: output: 0 files updated, 0 files merged, 0 files removed, 0 files unresolved command: END (0.29s elapsed) command: START command: hg parent --template {node|short} command: cwd: mozharness command: output: fea220075a82 command: END (0.26 elapsed) command: START command: hg tag -u stage-ffxbld -r production -m "Added THUNDERBIRD_24_0b2_RELEASE THUNDERBIRD_24_0b2_BUILD1 tag(s) for changeset production. DONTBUILD CLOSED TREE a=release" -f THUNDERBIRD_24_0b2_RELEASE THUNDERBIRD_24_0b2_BUILD1 command: cwd: mozharness command: output: command: END (0.33s elapsed) retry: Calling <function out at 0x18e0aa0> with args: (), kwargs: {'ssh_username': 'stage-ffxbld', 'remote': 'https://hg.mozilla.org/users/raliiev_mozilla.com/mozharness', 'ssh_key': '/home/mock_mozilla/.ssh/ffxbld_dsa', 'src': 'mozharness'}, attempt #1 command: START command: hg -q out --template "{node} {branches} " -e "ssh -l stage-ffxbld -i /home/mock_mozilla/.ssh/ffxbld_dsa" https://hg.mozilla.org/users/raliiev_mozilla.com/mozharness command: cwd: mozharness warning: hg.mozilla.org certificate with fingerprint 10:78:e8:57:2d:95:de:7c:de:90:bd:22:e1:38:17:67:c5:a7:9c:14 not verified (check hostfingerprints or web.cacerts config setting) command: output: 4083e49ae568e6733fac1ca7a0c3c4319e98d4b8 production command: END (0.57 elapsed) command: START command: hg -q out --template "{node} {branches} " -e "ssh -l stage-ffxbld -i /home/mock_mozilla/.ssh/ffxbld_dsa" ssh://hg.mozilla.org/users/raliiev_mozilla.com/mozharness command: cwd: mozharness command: output: 4083e49ae568e6733fac1ca7a0c3c4319e98d4b8 production command: END (1.18 elapsed) command: START command: hg push -e "ssh -l stage-ffxbld -i /home/mock_mozilla/.ssh/ffxbld_dsa" --new-branch ssh://hg.mozilla.org/users/raliiev_mozilla.com/mozharness command: cwd: mozharness command: output: pushing to ssh://hg.mozilla.org/users/raliiev_mozilla.com/mozharness searching for changes remote: not trusting file /repo/hg/mozilla/users/raliiev_mozilla.com/mozharness/.hg/hgrc from untrusted user raliiev@mozilla.com, group scm_level_1 remote: not trusting file /repo/hg/mozilla/users/raliiev_mozilla.com/mozharness/.hg/hgrc from untrusted user raliiev@mozilla.com, group scm_level_1 remote: adding changesets remote: adding manifests remote: adding file changes remote: added 1 changesets with 1 changes to 1 files remote: Trying to insert into pushlog. remote: Please do not interrupt... remote: Inserted into the pushlog db successfully. command: END (1.45s elapsed)
Attachment #791397 - Flags: review?(nthomas)
Comment on attachment 791397 [details] [diff] [review] update twice Looks like it'll work fine for other use cases too, eg compare-locales (a tag instead of a branch), and partner-repacks (default branch).
Attachment #791397 - Flags: review?(nthomas) → review+
(In reply to Nick Thomas [:nthomas] from comment #10) > Comment on attachment 791397 [details] [diff] [review] > update twice > > Looks like it'll work fine for other use cases too, eg compare-locales (a > tag instead of a branch), and partner-repacks (default branch). Yes, it worked fine and as expected for them.
Status: REOPENED → RESOLVED
Closed: 12 years ago12 years ago
Resolution: --- → FIXED
Component: Release Automation → Mozharness
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: