905240 - HTMLInputElement.{width,height} getter should return 0 for type!='image'

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Mounir Lamouri (:mounir)]

Attachment: Pach

That is what Blink and the specifications seem to do. Have not checked IE and Webkit though. I assumes that the specification specified the sanest behaviour.

Comment 1

[Mounir Lamouri (:mounir)]

This is passing try: https://tbpl.mozilla.org/?tree=Try&rev=58a8efe8547d

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 790298 [details] [diff] [review]
Pach

Review of attachment 790298 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, and sorry for the delay.

::: content/html/content/test/forms/test_input_attributes_reflection.html
@@ +28,5 @@
> +  element[attr] = 12;
> +  is(element.getAttribute(attr), '12', 'setting ' + attr + ' changes the content attribute');
> +
> +  element.removeAttribute(attr);
> +  is(element.getAttribute(attr), null);

Please use ise() when comparing to null

@@ +36,5 @@
> +  document.getElementById('content').appendChild(element);
> +  isnot(element[attr], 0, attr + ' represents the dimension of the element if type=image');
> +
> +  element.setAttribute(attr, '42');
> +  isnot(element[attr], 0, attr + ' represents the dimension of the element if type=image');

Consider also testing that it doesn't return 42

Comment 3

[Mounir Lamouri (:mounir)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6890020285a1

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/6890020285a1

Comment 5

[Kohei Yoshino]

https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/26/Site_Compatibility