Closed
Bug 905252
Opened 12 years ago
Closed 11 years ago
Tutorials need to be included in remix
Categories
(Webmaker Graveyard :: Popcorn Maker, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: Jacob, Assigned: thecount)
Details
(Whiteboard: mozfest)
Attachments
(1 file)
I made a tutorial that shows up here
https://popcorn.webmaker.org/editor/61388/edit
but not in the remix
https://jake.makes.org/popcorn/1bd8/remix
so nobody can see it but me at the moment.
Assignee | ||
Comment 1•12 years ago
|
||
This worked at some point.
Something happened.
After a bit of investigation, it looks like the remixedFromUrl in the popcorn data is undefined when it shouldn't be.
Assignee | ||
Updated•11 years ago
|
Whiteboard: mozfest
Assignee | ||
Comment 2•11 years ago
|
||
Fixed, but, I think something went wrong and some point and have not tracked all that down yet.
This change here is a red flag that something else might be broken: https://github.com/mozilla/popcorn.webmaker.org/pull/230/files#L0R44
I'm adding jbuck to this review too, in case he can see something I am not.
Attachment #810825 -
Flags: review?(schranz.m)
Attachment #810825 -
Flags: review?(jon)
Updated•11 years ago
|
Attachment #810825 -
Flags: review?(schranz.m) → review-
Assignee | ||
Updated•11 years ago
|
Attachment #810825 -
Flags: review- → review?(schranz.m)
Assignee | ||
Comment 3•11 years ago
|
||
Comment on attachment 810825 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/230
In person r+
Attachment #810825 -
Flags: review?(schranz.m)
Attachment #810825 -
Flags: review?(jon)
Attachment #810825 -
Flags: review+
Assignee | ||
Comment 4•11 years ago
|
||
Staged: https://github.com/mozilla/popcorn.webmaker.org/commit/8d9b03fbe9c106b8d945d1407b49c7b2f3ed2343
Needs verification.
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: needinfo?(scott)
Resolution: --- → FIXED
Assignee | ||
Updated•11 years ago
|
Status: RESOLVED → VERIFIED
Flags: needinfo?(scott)
Updated•11 years ago
|
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in
before you can comment on or make changes to this bug.
Description
•