Closed Bug 905252 Opened 9 years ago Closed 9 years ago

Tutorials need to be included in remix

Categories

(Webmaker Graveyard :: Popcorn Maker, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: Jacob, Assigned: thecount)

Details

(Whiteboard: mozfest)

Attachments

(1 file)

I made a tutorial that shows up here

https://popcorn.webmaker.org/editor/61388/edit

but not in the remix
https://jake.makes.org/popcorn/1bd8/remix

so nobody can see it but me at the moment.
This worked at some point.

Something happened.

After a bit of investigation, it looks like the remixedFromUrl in the popcorn data is undefined when it shouldn't be.
Whiteboard: mozfest
Fixed, but, I think something went wrong and some point and have not tracked all that down yet.

This change here is a red flag that something else might be broken: https://github.com/mozilla/popcorn.webmaker.org/pull/230/files#L0R44

I'm adding jbuck to this review too, in case he can see something I am not.
Attachment #810825 - Flags: review?(schranz.m)
Attachment #810825 - Flags: review?(jon)
Attachment #810825 - Flags: review?(schranz.m) → review-
Attachment #810825 - Flags: review- → review?(schranz.m)
Comment on attachment 810825 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/230

In person r+
Attachment #810825 - Flags: review?(schranz.m)
Attachment #810825 - Flags: review?(jon)
Attachment #810825 - Flags: review+
Staged: https://github.com/mozilla/popcorn.webmaker.org/commit/8d9b03fbe9c106b8d945d1407b49c7b2f3ed2343

Needs verification.
Status: NEW → RESOLVED
Closed: 9 years ago
Flags: needinfo?(scott)
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
Flags: needinfo?(scott)
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in before you can comment on or make changes to this bug.