905293 - [FIG] Hard to swipe between panels on tablets

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: General, defect, P1)

Description

[Ian Barlow (:ibarlow)]

We need to adjust the swipe threshold for moving between panels on the Awesomescreen. 

It's easy to do on phones, but on tablets the threshold is larger than what can comfortably be achieved by a thumb swipe.

Comment 1

[Sriram Ramasubramanian [:sriram]]

What's needed here?

Comment 2

[Ian Barlow (:ibarlow)]

A smaller swipe threshold for switching panels, so that you can comfortably swipe with your thumb to move from panel to panel.

Comment 3

[Sriram Ramasubramanian [:sriram]]

Hacking the thumb tracking logic will make us re-write entire ViewPager tracking. At this point in the cycle, that approach feels scary. Also, we have a TabWidget in tablets, that the users can tap to switch between pages -- instead of relying on scrolling between pages. Shall we mark this WONTFIX or track it for 27?

Comment 4

[Lucas Rocha (:lucasr)]

(In reply to Sriram Ramasubramanian [:sriram] from comment #3)
> Hacking the thumb tracking logic will make us re-write entire ViewPager
> tracking. At this point in the cycle, that approach feels scary. Also, we
> have a TabWidget in tablets, that the users can tap to switch between pages
> -- instead of relying on scrolling between pages. Shall we mark this WONTFIX
> or track it for 27?

We could probably override ViewPager's touch handling and add some logic "on top" of the default behaviour. However, this is prone to breaking the ViewPager in subtle ways.

Unless ibarlow feels strongly about it, I'm leaning towards a WONTFIX here.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Lucas Rocha (:lucasr) from comment #4)

> We could probably override ViewPager's touch handling and add some logic "on
> top" of the default behaviour. However, this is prone to breaking the
> ViewPager in subtle ways.
> 
> Unless ibarlow feels strongly about it, I'm leaning towards a WONTFIX here.

Overriding the built-in behavior is always worrisome. We lose any platform fixes and future changes. We also add our own bugs.

I'd like to vote for WONTFIX too.

Comment 6

[Wesley Johnston (:wesj)]

It might be interesting to look at the homescreen launcher for Tablets and see if they're using different values here. While its not a ViewPager, I'd expect they're using the same system values and should have similar behavior.

Do you find the homescreen hard to flip on the same device ian?

Comment 7

[Ian Barlow (:ibarlow)]

I would say the Android home screen and our Awesomescreen are equally hard to swipe through. Which gives me an uneasy feeling about the future of this bug :(

Comment 8

[Ian Barlow (:ibarlow)]

I guess it's a wontfix for now

:(