905376 - FadedTextView can be achieved using fadingEdge

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[Sriram Ramasubramanian [:sriram]]

:sigh: As per Romain Guy, FadedTextView can be achieved using android's fadingEdgeLength.

Comment 1

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

Removed the file.
Changed the XMLs.
Changed the styles. (fadingEdge on pre-ICS, requiresFadingEdge on post ICS).

:sigh: So much work for something already available. :(

Comment 2

[Sriram Ramasubramanian [:sriram]]

Attachment: Profile: Fading edge method

This is the draw call profiling with fadingEdge method. It's alarming. The list is stuttering (as its taking more than 32ms -- twice than normal -- for each frame).

Comment 3

[Sriram Ramasubramanian [:sriram]]

Attachment: Profile: FadedTextView

Here's my approach. Everything is faded as before. But the each frame is drawn within 16ms. We for the win.

Let's kill this bug again. We are actually good with our FadedTextView approach. :D :D

Comment 4

[Lucas Rocha (:lucasr)]

Comment on attachment 790446 [details] [diff] [review]
Patch

Review of attachment 790446 [details] [diff] [review]:
-----------------------------------------------------------------

Cool.

Comment 5

[Sriram Ramasubramanian [:sriram]]

Oops. Sorry. Though this approach is simpler, we can't use this. This causes regression in scrolling. To avoid it, we need to supply a solid color -- which causes overdraw. It's better as how we have it now. Same performance as what this patch (with solid color) would give us.