Closed
Bug 905414
Opened 12 years ago
Closed 12 years ago
Signature summary multiplies percentage numbers by 100
Categories
(Socorro :: Webapp, task)
Socorro
Webapp
Tracking
(Not tracked)
VERIFIED
FIXED
56
People
(Reporter: peterbe, Assigned: peterbe)
Details
Attachments
(2 files)
The signature summary mware used to return things like `"percentage": 0.33}` when it actually meant to say 33%. Now the mware does it properly so the django code doesn't need to multiply by 100.
| Assignee | ||
Comment 1•12 years ago
|
||
QA steps to reproduce:
1. Go to Top Crashers
2. Click any signature
3. Load the Signature Summary
4. Should not see things like 7541.24% or 10000.0%
Assignee: nobody → peterbe
Status: NEW → ASSIGNED
Comment 2•12 years ago
|
||
Thanks Peter! Here's an accompanying screenshot.
Updated•12 years ago
|
OS: Mac OS X → All
Hardware: x86 → All
| Assignee | ||
Comment 3•12 years ago
|
||
Comment 4•12 years ago
|
||
Commits pushed to master at https://github.com/mozilla/socorro
https://github.com/mozilla/socorro/commit/7d0d678de425966f545b2483c92d70c21c2c9665
fixes bug 905414 - Signature summary multiplies percentage numbers by 100
https://github.com/mozilla/socorro/commit/3f7fd046cf7959e38678cf569e1ea706f1135b09
Merge pull request #1403 from peterbe/bug-905414-signature-summary-multiplies-percentage-numbers-by-100
fixes bug 905414 - Signature summary multiplies percentage numbers by 100
Updated•12 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•12 years ago
|
Target Milestone: --- → 56
Comment 5•12 years ago
|
||
QA verified on stage - percentages sum up to 100%
https://crash-stats.allizom.org/report/list?product=Firefox&range_value=7&range_unit=days&date=2013-08-15&signature=SetWindowLongPtrWHook%28HWND__*%2C+int%2C+__int64%29&version=Firefox%3A26.0a1
Updated•12 years ago
|
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•