Closed Bug 905507 Opened 11 years ago Closed 4 years ago

Ensure js/public/*.h are standalone

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED WONTFIX

People

(Reporter: n.nethercote, Unassigned)

Details

(Whiteboard: [js:t])

js/public/GCAPI.h won't compile unless jsapi.h is #included first. This is a violation of our standard "headers must be standalone" policy. This is biting me in bug 905017. Some of the other header in js/public/ may have the same problem. Once they are fixed, to prevent regression we need to have .cpp files that #include each of these headers as their first #include statement. (The .cpp files wouldn't need to contain anything else.) A bit ugly, but I don't see how else to avoid regressing.
> js/public/GCAPI.h won't compile unless jsapi.h is #included first. My patches in bug 905017 will fix this particular case. But the general problem remains.
Summary: js/GCAPI.h won't compile unless jsapi.h is #included first → Ensure js/public/*.h are standalone
Assignee: n.nethercote → nobody
No assignee, updating the status.
Status: ASSIGNED → NEW
No assignee, updating the status.
No assignee, updating the status.
No assignee, updating the status.
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.