Closed Bug 905542 Opened 6 years ago Closed 6 years ago

Inline function 'IsNull()' used but never defined with nullable unions

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla26

People

(Reporter: Ms2ger, Assigned: dzbarsky)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Looks like we missed a bodyInHeader=True for IsNull/SetNull.
Attached patch cgunionstructSplinter Review
What does it mean to have inline=True but bodyInHeader=False?  Perhaps we should rename bodyInHeader to inline and get rid of the current inline?  I think the compiler will happily make its own inlining decisions regardless of whether we use the keyword.
Assignee: nobody → dzbarsky
Status: NEW → ASSIGNED
Attachment #791887 - Flags: review?(Ms2ger)
Comment on attachment 791887 [details] [diff] [review]
cgunionstruct

Review of attachment 791887 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks. I'll try to look into the default.
Attachment #791887 - Flags: review?(Ms2ger) → review+
https://hg.mozilla.org/mozilla-central/rev/534e18e202da
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.