Closed
Bug 905542
Opened 11 years ago
Closed 11 years ago
Inline function 'IsNull()' used but never defined with nullable unions
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla26
People
(Reporter: Ms2ger, Assigned: dzbarsky)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
1.51 KB,
patch
|
Ms2ger
:
review+
|
Details | Diff | Splinter Review |
Looks like we missed a bodyInHeader=True for IsNull/SetNull.
|
Assignee | |
Comment 1•11 years ago
|
||
What does it mean to have inline=True but bodyInHeader=False? Perhaps we should rename bodyInHeader to inline and get rid of the current inline? I think the compiler will happily make its own inlining decisions regardless of whether we use the keyword.
|
Reporter | |
Comment 2•11 years ago
|
||
Comment on attachment 791887 [details] [diff] [review]
cgunionstruct
Review of attachment 791887 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good, thanks. I'll try to look into the default.
Attachment #791887 -
Flags: review?(Ms2ger) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
|
||
Comment 4•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•