Closed Bug 905591 Opened 12 years ago Closed 12 years ago

Intermittent testVkbOverlap | URL typed properly - got http://mochi.test:8888/tests/robocop/test_viewport.sjs?metadata=initial-scale%3D1.0%2C%20user-scalable%3Dno

Categories

(Firefox for Android Graveyard :: General, defect, P1)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
All
Android
Type:
defect

Tracking

(firefox24 unaffected, firefox25 unaffected, firefox26 verified)

Status:
VERIFIED FIXED
Milestone:
Firefox 26
Tracking Flags:
Tracking Status
firefox24 --- unaffected
firefox25 --- unaffected
firefox26 --- verified

People

(Reporter: lucasr, Assigned: lucasr)

References

Details

(Keywords: intermittent-failure, Whiteboard: [fixed-fig])

Attachments

(4 files)

Load URLs in PixelTest without requiring input injection
2.31 KB, patch
gbrown
: review+
nalexander
: feedback+
Details | Diff | Splinter Review
Rename BaseTest's loadUrl to inputAndLoadUrl
19.21 KB, patch
gbrown
: review+
Details | Diff | Splinter Review
Use Tabs.loadUrl() instead of Tabs.loadUrlInTab() in JavascriptTest
2.96 KB, patch
nalexander
: review+
Details | Diff | Splinter Review
Load URLs in PixelTest without requiring input injection
2.39 KB, patch
gbrown
: review+
Details | Diff | Splinter Review
Seeing this a bit randomly in fig.
Priority: -- → P1
https://tbpl.mozilla.org/php/getParsedLog.php?id=26563748&tree=Fig&full=1#error0 17:22:34 INFO - 08-14 17:22:29.968 I/GeckoSuggestClient( 2102): Not connected to network 17:22:34 INFO - 08-14 17:22:30.054 I/GeckoSuggestClient( 2102): Not connected to network 17:22:34 INFO - 08-14 17:22:30.148 I/GeckoSuggestClient( 2102): Not connected to network 17:22:34 INFO - 08-14 17:22:30.148 I/InputDispatcher( 1403): Dropped event because it is stale. 17:22:34 INFO - 08-14 17:22:30.148 I/InputDispatcher( 1403): Dropped event because it is stale. 17:22:34 INFO - 08-14 17:22:30.148 I/InputDispatcher( 1403): Dropped event because it is stale. 17:22:34 INFO - 08-14 17:22:30.148 I/InputDispatcher( 1403): Dropped event because it is stale. 17:22:34 INFO - 08-14 17:22:30.148 I/InputDispatcher( 1403): Dropped event because it is stale. 17:22:34 INFO - 08-14 17:22:30.148 I/InputDispatcher( 1403): Dropped event because it is stale. 17:22:34 INFO - 08-14 17:22:30.148 I/InputDispatcher( 1403): Dropped event because it is stale. 17:22:34 INFO - 08-14 17:22:30.148 I/InputDispatcher( 1403): Dropped event because it is stale. 17:22:34 INFO - 08-14 17:22:30.148 I/InputDispatcher( 1403): Dropped event because it is stale. 17:22:34 INFO - 08-14 17:22:30.148 W/WindowManager( 1403): Input event injection failed. 17:22:34 INFO - 08-14 17:22:30.148 W/WindowManager( 1403): Input event injection failed. 17:22:34 INFO - 08-14 17:22:30.148 W/WindowManager( 1403): Input event injection failed. 17:22:34 INFO - 08-14 17:22:30.148 W/WindowManager( 1403): Input event injection failed. 17:22:34 INFO - 08-14 17:22:30.148 W/WindowManager( 1403): Input event injection failed. 17:22:34 INFO - 08-14 17:22:30.148 W/WindowManager( 1403): Input event injection failed. 17:22:34 INFO - 08-14 17:22:30.148 W/WindowManager( 1403): Input event injection failed. 17:22:34 INFO - 08-14 17:22:30.148 W/WindowManager( 1403): Input event injection failed. 17:22:34 INFO - 08-14 17:22:30.148 W/WindowManager( 1403): Input event injection failed. 17:22:34 INFO - 08-14 17:22:30.156 I/InputDispatcher( 1403): Dropped event because it is stale. 17:22:34 INFO - 08-14 17:22:30.156 I/InputDispatcher( 1403): Dropped event because it is stale. 17:22:34 INFO - 08-14 17:22:30.156 I/InputDispatcher( 1403): Dropped event because it is stale. 17:22:34 INFO - 08-14 17:22:30.156 I/InputDispatcher( 1403): Dropped event because it is stale. 17:22:34 INFO - 08-14 17:22:30.156 I/InputDispatcher( 1403): Dropped event because it is stale. 17:22:34 INFO - 08-14 17:22:30.156 I/InputDispatcher( 1403): Dropped event because it is stale. 17:22:34 INFO - 08-14 17:22:30.156 I/InputDispatcher( 1403): Dropped event because it is stale. 17:22:34 INFO - 08-14 17:22:30.156 I/InputDispatcher( 1403): Dropped event because it is stale. 17:22:34 INFO - 08-14 17:22:30.156 I/InputDispatcher( 1403): Dropped event because it is stale. 17:22:34 INFO - 08-14 17:22:30.156 I/InputDispatcher( 1403): Dropped event because it is stale. 17:22:34 INFO - 08-14 17:22:30.156 I/InputDispatcher( 1403): Dropped event because it is stale. 17:22:34 INFO - 08-14 17:22:30.156 I/InputDispatcher( 1403): Dropped event because it is stale. 17:22:34 INFO - 08-14 17:22:30.156 I/InputDispatcher( 1403): Dropped event because it is stale. 17:22:34 INFO - 08-14 17:22:30.156 I/InputDispatcher( 1403): Dropped event because it is stale. 17:22:34 INFO - 08-14 17:22:30.156 W/WindowManager( 1403): Input event injection failed. 17:22:34 INFO - 08-14 17:22:30.156 W/WindowManager( 1403): Input event injection failed. 17:22:34 INFO - 08-14 17:22:30.156 W/WindowManager( 1403): Input event injection failed. 17:22:34 INFO - 08-14 17:22:30.156 W/WindowManager( 1403): Input event injection failed. 17:22:34 INFO - 08-14 17:22:30.156 W/WindowManager( 1403): Input event injection failed. 17:22:34 INFO - 08-14 17:22:30.156 W/WindowManager( 1403): Input event injection failed. 17:22:34 INFO - 08-14 17:22:30.156 W/WindowManager( 1403): Input event injection failed. 17:22:34 INFO - 08-14 17:22:30.156 W/WindowManager( 1403): Input event injection failed. 17:22:34 INFO - 08-14 17:22:30.156 W/WindowManager( 1403): Input event injection failed. 17:22:34 INFO - 08-14 17:22:30.156 W/WindowManager( 1403): Input event injection failed. 17:22:34 INFO - 08-14 17:22:30.156 W/WindowManager( 1403): Input event injection failed. 17:22:34 INFO - 08-14 17:22:30.156 W/WindowManager( 1403): Input event injection failed. 17:22:34 INFO - 08-14 17:22:30.156 W/WindowManager( 1403): Input event injection failed. 17:22:34 INFO - 08-14 17:22:30.156 W/WindowManager( 1403): Input event injection failed. 17:22:34 INFO - 08-14 17:22:30.164 I/InputDispatcher( 1403): Dropped event because it is stale. 17:22:34 INFO - 08-14 17:22:30.164 I/InputDispatcher( 1403): Dropped event because it is stale. 17:22:34 INFO - 08-14 17:22:30.164 W/WindowManager( 1403): Input event injection failed. 17:22:34 INFO - 08-14 17:22:30.164 W/WindowManager( 1403): Input event injection failed. 17:22:34 INFO - 08-14 17:22:30.195 I/Robocop ( 2102): 3 INFO TEST-UNEXPECTED-FAIL | testVkbOverlap | URL typed properly - got http://mochi.test:8888/tests/robocop/test_viewport.sjs?metadata=initial-scale%3D1.0%2C%20user-scalable%3Dno, expected http://mochi.test:8888/tests/robocop/test_viewport.sjs?metadata=initial-scale%3D1.0%2C%20user-sca I have not seen these "Input event injection failed" or "Dropped event because it is stale" messages before.
Pushed a tentative fix to try: https://tbpl.mozilla.org/?tree=Try&rev=891e623e0ec5
testVkbOverlap is fixed with the patch. But testTabHistory now fails. Pushed another tentative fix: https://tbpl.mozilla.org/?tree=Try&rev=47b010bbf46a
Assignee: nobody → lucasr.at.mozilla
Pushed this once more to try: https://tbpl.mozilla.org/?tree=Try&rev=bc581e77c0f2
Comment on attachment 791575 [details] [diff] [review] Load URLs in PixelTest without requiring input injection Review of attachment 791575 [details] [diff] [review]: ----------------------------------------------------------------- Reluctant r+ with concerns: -- We're avoiding a problem we do not understand. I would like to see more investigation of why input injection is failing on fig, perhaps in a follow-up bug. -- The change to BaseTest.loadUrlInTab affects all the JavascriptTests. :lucasr is checking this with a new try run. We should also get :nalexander's feedback in case he has a concern about that change. ::: mobile/android/base/tests/BaseTest.java.in @@ +260,5 @@ > try { > ClassLoader classLoader = getActivity().getClassLoader(); > Class tabsClass = classLoader.loadClass("org.mozilla.gecko.Tabs"); > Method getInstance = tabsClass.getMethod("getInstance"); > + Method loadUrlInTab = tabsClass.getMethod("loadUrl", String.class); nit -- s/loadUrlInTab/loadUrl/
Attachment #791575 - Flags: review?(gbrown)
Attachment #791575 - Flags: review+
Attachment #791575 - Flags: feedback?(nalexander)
(In reply to Geoff Brown [:gbrown] from comment #15) > Comment on attachment 791575 [details] [diff] [review] > Load URLs in PixelTest without requiring input injection > > Review of attachment 791575 [details] [diff] [review]: > ----------------------------------------------------------------- > > Reluctant r+ with concerns: > -- We're avoiding a problem we do not understand. I would like to see more > investigation of why input injection is failing on fig, perhaps in a > follow-up bug. Filed bug 906719 to add a test to cover this. > -- The change to BaseTest.loadUrlInTab affects all the JavascriptTests. > :lucasr is checking this with a new try run. We should also get > :nalexander's feedback in case he has a concern about that change. > > ::: mobile/android/base/tests/BaseTest.java.in > @@ +260,5 @@ > > try { > > ClassLoader classLoader = getActivity().getClassLoader(); > > Class tabsClass = classLoader.loadClass("org.mozilla.gecko.Tabs"); > > Method getInstance = tabsClass.getMethod("getInstance"); > > + Method loadUrlInTab = tabsClass.getMethod("loadUrl", String.class); > > nit -- s/loadUrlInTab/loadUrl/ Done.
Patch caused orangeness in testTabHistory. Pushed a tentative fix to try: https://tbpl.mozilla.org/?tree=Try&rev=11c24b23237a I'll submit a new patch if the build goes green on try.
Comment on attachment 791575 [details] [diff] [review] Load URLs in PixelTest without requiring input injection Review of attachment 791575 [details] [diff] [review]: ----------------------------------------------------------------- ::: mobile/android/base/tests/BaseTest.java.in @@ +260,5 @@ > try { > ClassLoader classLoader = getActivity().getClassLoader(); > Class tabsClass = classLoader.loadClass("org.mozilla.gecko.Tabs"); > Method getInstance = tabsClass.getMethod("getInstance"); > + Method loadUrlInTab = tabsClass.getMethod("loadUrl", String.class); I see that the tab interface has changed in Tabs.java, but this is a confusing update. Having loadUrlInTab call loadUrl (with no arguments!) is bad form; I'd rather you duplicate this method and implement loadUrl and loadUrlInTab (that pass-through as appropriate). Then you won't be changing any of the other test's behaviour and possibly break their expectations. If you are confident that the other tests should be calling loadUrl (and *not* loadUrlInTab -- I don't think any JavascriptTest will care) you could rename this method. ::: mobile/android/base/tests/PixelTest.java.in @@ +7,5 @@ > private static final long PAINT_CLEAR_DELAY = 3000; // milliseconds > > protected final PaintedSurface loadAndGetPainted(String url) { > Actions.RepeatedEventExpecter paintExpecter = mActions.expectPaint(); > + loadUrlInTab(url); I see no reason this wouldn't work, since we explicitly block until paint below. @@ +12,5 @@ > paintExpecter.blockUntilClear(PAINT_CLEAR_DELAY); > paintExpecter.unregisterListener(); > PaintedSurface p = mDriver.getPaintedSurface(); > if (p == null) { > mAsserter.ok(p != null, "checking that painted surface loaded", nit: kill trailing whitespace.
Attachment #791575 - Flags: feedback?(nalexander) → feedback+
Attachment #792266 - Flags: review?(gbrown)
Comment on attachment 792267 [details] [diff] [review] Use Tabs.loadUrl() instead of Tabs.loadUrlInTab() in JavascriptTest Review of attachment 792267 [details] [diff] [review]: ----------------------------------------------------------------- wfm. I can't think of a JavascriptTest that would need a new tab; they all need to handle the case where they're the first test run.
Attachment #792267 - Flags: review?(nalexander) → review+
Attachment #792266 - Flags: review?(gbrown) → review+
Attachment #792343 - Flags: review?(gbrown) → review+
Depends on: 923109
Since there are no more fails, I’m setting this as verified.
Status: RESOLVED → VERIFIED
status-firefox26: fixed → verified
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: