905771 - Better lazy loading for contacts

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Kevin Grandon :kgrandon]

Splitting out just the lazy loading piece from 898969.

Comment 1

[Kevin Grandon :kgrandon]

Actually blocking the right bug, bug 871823.

Comment 2

[Kevin Grandon :kgrandon]

Attachment: Github pull request pointer

Hi Jose, Francisco - Wondering if one or both of you could review this patch? Thanks!

Comment 3

[Francisco Jordano [:arcturus] [:francisco]]

Hi Kevin, just did a quick review through the code and added some comments on github.

Now I'm going through deeper review, checking the integration with FB and webactivities.

Will try to have the review done by today.

Thanks a lot for the work!
F.

Comment 4

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 791013 [details]
Github pull request pointer

Thanks a lot Kevin,

with this changes sure the cold start improves a lot.

I've been through the code and agree with your comments there. Also tested it on the phone, specially with activities and fb, and working gracefully.

As well all the test are passing locally for me, so rplusing :)

Could you rebase before merging?

Thanks!
F.

Comment 5

[Kevin Grandon :kgrandon]

Thanks for the reviews!

Landed in master: https://github.com/mozilla-b2g/gaia/commit/aa22b7cfee556f704ca174ab608013eb469c83b1