Closed
Bug 905774
Opened 11 years ago
Closed 11 years ago
jsreflect.cpp uses baseops::GetPropertyDefault
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla26
People
(Reporter: bbenvie, Assigned: jorendorff)
Details
Attachments
(1 file)
|
13.31 KB,
patch
|
bhackett1024
:
review+
|
Details | Diff | Splinter Review |
Line 176 of jsreflect.cpp uses baseops::GetPropertyDefault to get the handlers from the builder object when provided to Reflect.parse as an option. This makes it so that a Scripted Proxy can't be used as the builder object, and I've also been told it is very bad mojo to be using GetPropertyDefault here.
|
Reporter | |
Comment 1•11 years ago
|
||
Actually, GetPropertyDefault is used in 5 places in jsreflect.cpp and I assume these all should be replaced.
|
|
Reporter | |
Updated•11 years ago
|
OS: Windows 8 → All
Hardware: x86_64 → All
|
|
Reporter | |
Updated•11 years ago
|
Summary: Reflect.parse uses baseops::GetPropertyDefault → jsreflect.cpp uses baseops::GetPropertyDefault
|
Assignee | |
Updated•11 years ago
|
Assignee: general → jorendorff
|
|
Assignee | |
Comment 2•11 years ago
|
||
Attachment #790989 -
Flags: review?(bhackett1024)
|
||
Updated•11 years ago
|
Attachment #790989 -
Flags: review?(bhackett1024) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/b4b1369c7595
|
||
Comment 4•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/b4b1369c7595
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in
before you can comment on or make changes to this bug.
Description
•