Closed
Bug 905846
Opened 11 years ago
Closed 11 years ago
compare-mozconfigs fails for win64 because there's no beta mozconfig
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla26
People
(Reporter: philor, Assigned: ehsan.akhgari)
References
Details
Attachments
(1 file)
|
4.30 KB,
patch
|
catlee
:
review+
|
Details | Diff | Splinter Review |
https://tbpl.mozilla.org/php/getParsedLog.php?id=26606818&tree=Mozilla-Central Adding an (as yet unused) beta mozconfig or not running it for that platform where we (as yet) don't care would work equally well, since either would stop it from being permaorange.
|
||
Comment 1•11 years ago
|
||
We should stop running this check for Windows 64 until we have a timeframe to ship it.
|
Reporter | |
Comment 2•11 years ago
|
||
Yeah, I liked that option better too, right up until I thought about someone in releng who was turning it on having to remember that way over in http://mxr.mozilla.org/mozilla-central/source/build/compare-mozconfig/compare-mozconfigs-wrapper.py#17, miles away from anything else they were touching, they needed to swap a None back to win64.
|
Assignee | |
Comment 3•11 years ago
|
||
|
||
Updated•11 years ago
|
Attachment #794831 -
Flags: review?(catlee) → review+
|
|
Assignee | |
Comment 4•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/e4ccc0fa8893
|
|
Reporter | |
Comment 5•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e4ccc0fa8893
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
|
||
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•