905916 - Create first browser integration test that loads a file from static server.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Browser, defect)

Comment 1

[James Lal [:lightsofapollo]]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/11569

Pointer to Github pull-request

Comment 2

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Isn't this duplicating the existing Gaia UI test in https://github.com/mozilla/gaia-ui-tests/blob/643d3f187148fc285b98d1edf394703bb320f6d9/gaiatest/tests/browser/test_browser_cell_data.py#L19?

Comment 3

[Dale Harvey (:daleharvey)]

Comment on attachment 791125 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/11569

There is a tiny nit on this, but very awesome and a huge thanks for getting to this before I did, a few things got in the way between the test runner landing and writing this.

I wont land this and give ben a chance to look at it, as I think we should all be familiar with the integration tests

Comment 4

[Dale Harvey (:daleharvey)]

@davehunt - Its very much a hello world test and is definitely duplicating the functionality, the problem is the gaia ui tests have very little buy in from the gaia devs, whether thats down to problems understanding it, python vs javascript whatever, I have been trying (badly) to push for us using what runners have existed so far but it hasnt happened

These tests are integrated into the gaia source, soon to be integrated into the workflow as a whole and look to be getting adoption in gaia, this test is really just James being super helpful and giving us devs who dont have experience with the tests so far a base for us to write tests from.

Going forward we will be writing tests for all new features and writing new tests for existing regressions and hopefully taking a whole bunch of strain off QA (both in terms of manually testsing and writing their own automated tests)

Comment 5

[Ben Francis [:benfrancis]]

I'm going to take a proper look at this and review, but marking sprintready to get it out of our triage query :)

Comment 6

[Dave Hunt [:davehunt] [he/him] ⌚BST]

(In reply to Dale Harvey (:daleharvey) from comment #4)
> @davehunt - Its very much a hello world test and is definitely duplicating
> the functionality, the problem is the gaia ui tests have very little buy in
> from the gaia devs, whether thats down to problems understanding it, python
> vs javascript whatever, I have been trying (badly) to push for us using what
> runners have existed so far but it hasnt happened
> 
> These tests are integrated into the gaia source, soon to be integrated into
> the workflow as a whole and look to be getting adoption in gaia, this test
> is really just James being super helpful and giving us devs who dont have
> experience with the tests so far a base for us to write tests from.
> 
> Going forward we will be writing tests for all new features and writing new
> tests for existing regressions and hopefully taking a whole bunch of strain
> off QA (both in terms of manually testsing and writing their own automated
> tests)

Yeah, I'm aware of the Python vs JavaScript concern, and having buy-in from the Gaia devs is critical so for that I'm +1 to whichever has that. That said, I'm not keen on having duplicated tests, so we should decide how to handle the situation where a new JS test duplicates a Python test. Should we delete the Python test? If so, we should be sure that the JS tests cover every aspect of the Python test before deleting. Perhaps there's a more appropriate place to discuss this?

Comment 7

[Ben Francis [:benfrancis]]

I'm having problems getting integration tests to run under Ubuntu so I'm not sure if you want to wait on my review before landing this.

James is helping me fix Node.

Comment 9

[ffos-browser]

A Pivotal Tracker story has been created for this Bug: http://www.pivotaltracker.com/story/show/55511034

Comment 10

[Dale Harvey (:daleharvey)]

I have reproduced the 'incorrect iframe', I am trying to get time to debug it but its a plain test bug so it shouldnt be that hard, this is a "huge" priority for the browser (we are still seeing regressions that tests could have prevented), so if you could also make sure to debug this as well ben, james has done most of our work for us and this shouldnt have been sitting here for 10 days

Comment 11

[Dale Harvey (:daleharvey)]

Attachment: Add initial integration test and static server plumbing

The initial setup ran before the browser was ready, added some instrumention  to the browser to ensure it has loaded

Comment 12

[Dale Harvey (:daleharvey)]

Comment on attachment 796996 [details] [review]
Add initial integration test and static server plumbing

Carrying my r+ as this is mostly James' work which I already reviewed, Ben this is passing on ubuntu for me now (ping me if you have problems, want this merged asap)

Comment 13

[James Lal [:lightsofapollo]]

https://github.com/mozilla-b2g/gaia/commit/a768bc91b98792f6ea8037a98fee3fbbea0b9f65

Comment 14

[Ben Francis [:benfrancis]]

Comment on attachment 796996 [details] [review]
Add initial integration test and static server plumbing

Passes for me too! \o/

Thanks for fixing this Dale, now let the testing commence!