Closed
Bug 905920
Opened 13 years ago
Closed 13 years ago
xpcom/base/nsCycleCollector.cpp:1045:17: error: no type named 'ThreadLocal' in namespace 'mozilla' (non-SPS)
Categories
(Core :: XPCOM, defect)
Tracking
()
RESOLVED
FIXED
mozilla26
People
(Reporter: jbeich, Assigned: jbeich)
Details
Attachments
(1 file)
|
613 bytes,
patch
|
khuey
:
review+
|
Details | Diff | Splinter Review |
On platforms without SPS profiler the build is broken due to
GeckoProfiler.h not including ThreadLocal.h.
xpcom/base/nsCycleCollector.cpp:1045:17: error: no type named
'ThreadLocal' in namespace 'mozilla'
static mozilla::ThreadLocal<CollectorData*> sCollectorData;
~~~~~~~~~^
xpcom/base/nsCycleCollector.cpp:1045:28: error: expected
unqualified-id
static mozilla::ThreadLocal<CollectorData*> sCollectorData;
^
xpcom/base/nsCycleCollector.cpp:1237:31: error: use of undeclared
identifier 'sCollectorData'
CollectorData *data = sCollectorData.get();
^
Attachment #791138 -
Flags: review?(continuation)
Comment on attachment 791138 [details] [diff] [review]
explicitly include
Review of attachment 791138 [details] [diff] [review]:
-----------------------------------------------------------------
r=me
Attachment #791138 -
Flags: review?(continuation) → review+
Oops, reverting bug 901630 doesn't help. I think something
else broke implicit dependency on ThreadLocal.h
Do you think this is worth bisecting?
No longer blocks: 901630
It was Bug 839025.
|
||
Comment 4•13 years ago
|
||
Comment on attachment 791138 [details] [diff] [review]
explicitly include
This fixes the build on OpenBSD for me, so i pushed it :
https://hg.mozilla.org/integration/mozilla-inbound/rev/b9465d94fff3
|
||
Updated•13 years ago
|
Assignee: nobody → jbeich
|
||
Comment 5•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in
before you can comment on or make changes to this bug.
Description
•