905954 - [wasabi] B2G CDMA: don't change to holding state when we switch two calls

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Hsin-Yi Tsai (she/her) [:hsinyi]]

It's a follow-up for bug 822210. We shouldn't change the internal call state to 'holding' as we will never be able to make it back to 'connected'. The state will be not synchronous with the real RIL/network state.

Comment 1

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Attachment: 9059547.patch

Not changing to HOLDING state

Comment 2

[Gabriele Svelto [:gsvelto] (PTO)]

Hsin-Yi, do I need for this to land before finishing bug 882980?

Comment 3

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to Gabriele Svelto [:gsvelto] from comment #2)
> Hsin-Yi, do I need for this to land before finishing bug 882980?

I guess not. 
But with this landed, we have fully support the scenario (step 4) and you won't get trouble in gaia:

1. 1st call is established.
2. 2nd call is also answered. 1st call on hold.
3. End either 1st or 2nd call from the other end, not DUT, device will connect to the left one directly.
4. MT call to device from another line.
(Android version seems to not able to handle this anymore, I can picked 3rd call, but no UI to switch call again. The only way I can talk to the on hold call is end 3rd call from its originator.)

Comment 4

[Francis Lee [:frlee]]

according to the RIL triage meeting consensus on 8/22, koi+ this issue.

Comment 5

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 791202 [details] [diff] [review]
9059547.patch

Review of attachment 791202 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks!

Comment 6

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Thanks for the review.

https://hg.mozilla.org/integration/b2g-inbound/rev/f2554bbef3b9

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/f2554bbef3b9