905955 - B2G RIL: mms data connection does not get disconnected

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Jessica Jong [:jessica] (inactive)]

Attachment: logcat.log

MMS can be sent sucesfully, but the mms data connection remains connected, and it's treated as the default connection.

From the attached log, default route is set for rmnet1 (emome).
08-16 16:44:11.021 I/Gecko   (  143): -*- NetworkManager: Going to change route and DNS to rmnet1
08-16 16:44:11.031 I/Gecko   (  143): Network Worker: received message: {"cmd":"setDefaultRouteAndDNS","ifname":"rmnet1","oldIfname":"rmnet0","gateway_str":"10.38.243.129","dns1_str":"10.1.7.1","dns2_str":"10.1.7.2"}

I can reproduce it 100%, will further confirm with other peers.

Comment 1

[Shian-Yow Wu [:swu]]

Is it reproduced with Moz RIL or QC RIL?

Comment 2

[Jessica Jong [:jessica] (inactive)]

I use Buri for testing/development, so it should be QC RIL, right?
Vicamo found out that some of the properties in RILNetworkInterface are treated as "static", I will try to fix them and see if it solves the problem.

Comment 3

[Shian-Yow Wu [:swu]]

Mozilla RIL is the RIL built from mozilla-central, and QC RIL is the RIL built by QC instead.
I saw some QCRIL keywords in the log, that's why I asked to confirm.

If the code is built by you instead of using a production image, then it must be Mozilla RIL.

Comment 4

[Jessica Jong [:jessica] (inactive)]

Yes, I built it myself from the source code cloned from mozilla-b2g (master branch).
Will there be any difference between the ril built by us (Mozilla RIL) and  the ril built by QC (QC RIL)?

Thanks.

Comment 5

[Shian-Yow Wu [:swu]]

We cannot fix the bug if it's QC RIL, since we don't have the source code.

Comment 6

[Jessica Jong [:jessica] (inactive)]

I get it now. Thanks for the explanation.

Comment 7

[Jessica Jong [:jessica] (inactive)]

Attachment: fix mms not disconnected patch

connectedTypes was initialized in RILNetworkInterface.prototype, so it was treated as "static". This led to mms's RILNetworkInterface also had "default" in its connectedTypes when default data was connected.

Comment 8

[Vicamo Yang [:vicamo][:vyang]]

Comment on attachment 792734 [details] [diff] [review]
fix mms not disconnected patch

Review of attachment 792734 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you!

Comment 9

[Vicamo Yang [:vicamo][:vyang]]

b2g18 is also affected.
http://mxr.mozilla.org/mozilla-b2g18/source/dom/system/gonk/RadioInterfaceLayer.js#3092

Comment 10

[Vicamo Yang [:vicamo][:vyang]]

https://hg.mozilla.org/integration/b2g-inbound/rev/25721ca5b28d

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/25721ca5b28d

Comment 13

[Julien Wajsberg [:julienw]]

Attachment: b2g18 patch

I second the leo nomination. The attached patch fixed the bug on my 1.1 device.

Some vars have been renamed so asking review to make sure it's correct (but I think it is).

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/c8a784074f42

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18_v1_1_0_hd/rev/c8a784074f42