Closed Bug 906002 Opened 11 years ago Closed 11 years ago

External API build busted after various bugs

Categories

(MailNews Core :: Build Config, defect)

Product:
MailNews Core
Component:
Build Config
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 26.0

People

(Reporter: neil, Assigned: neil)

Details

Attachments

(1 file)

Proposed patch
13.91 KB, patch
jcranmer
: review+
Details | Diff | Splinter Review 
A core change stopped us from building s/mime as a separate component because smime/build/Makefile.in did not contain FORCE_SHARED_LIB=1. Then a dependency from s/mime to mime was introduced that invisibly broke s/mime because of the core change. Then the smime/build/Makefile.in was changed because nobody realised that it wasn't building what it was supposed to (import/build/Makefile.in was also affected but in its case a simple backout suffices).

Because I can't easily figure out how to get s/mime to depend on mime across libraries, the easiest solution is to merge s/mime into the mail library.
Attached patch Proposed patch — — Splinter Review 
Assignee: nobody → neil
Status: NEW → ASSIGNED

        Attachment #791253 -
        Flags: review?(Pidgeot18)

        Attachment #791253 -
        Flags: review?(Pidgeot18) → review+

    
    

    
  
Pushed comm-central changeset d13e87b88205.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 26.0

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: