906039 - "New Guest Session" doesn't deserve a toplevel menu item

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Lucas Rocha (:lucasr)]

It's unlikely that it will be used very often by most users. Move it under 'Tools' maybe?

Thoughts?

Comment 1

[Lucas Rocha (:lucasr)]

On the other hand, once you're in a guest session, I do think it makes sense to have a toplevel menu item to exit.

Comment 2

[Ian Barlow (:ibarlow)]

I could see us doing that in a world where we had a better first run / tip experience built into Firefox where we could tell people about it. 

Let's leave it in the menu for now, but I agree we might want to reprioritize its position down the road.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: move-guest-session-tools

I talked to Ian on IRC and we seem OK to move the menu to a child of Tools. This patch moves the "New Guest Session" to "Tools" but leaves the "Exit Guest Session" as a top level menu.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/integration/fx-team/rev/53661597ccbf

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

This is primary UI for guest browsing and should get uplifted to fx25

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 809159 [details] [diff] [review]
move-guest-session-tools

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: We'd end up flipping the UI in the next release and get user confused
Testing completed (on m-c, etc.): landed on fx-team
Risk to taking this patch (and alternatives if risky): low risk, just moved the menu
String or IDL/UUID changes made by this patch: none

Comment 7

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 809159 [details] [diff] [review]
move-guest-session-tools

approving for uplift so there's no user confusion.

Comment 8

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 809159 [details] [diff] [review]
move-guest-session-tools

I was too quick - let's wait for this to get merged to central and then, if no unexpected surprises, it's a low risk fix and good to maintain UI consistency.

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/53661597ccbf

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/14f03ae49fbc
https://hg.mozilla.org/releases/mozilla-beta/rev/275ae41b74b6

Comment 11

[Teodora Vermesan (:TeoVermesan)]

Verified fixed on:
Build: Firefox for Android 25 Beta 6 (2013-10-08) and Firefox for Android 26 Aurora (2013-10-08)
Device: Samsung Galaxy Nexus
OS: Android 4.1.1