Closed
Bug 906045
Opened 11 years ago
Closed 11 years ago
pymake mochitest-* fails with runtests.py: error: no such option: --build-info-json
Categories
(Testing :: Mochitest, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla26
People
(Reporter: jimm, Assigned: ahal)
References
Details
(Keywords: regression)
Attachments
(2 files)
990 bytes,
patch
|
Details | Diff | Splinter Review | |
1.59 KB,
patch
|
jgriffin
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Reporter | ||
Comment 1•11 years ago
|
||
$ pymake mochitest-metro-chrome
make.py[0]: Entering directory 't:\Mozilla\MC-REL'
t:\Mozilla\mc\browser\build.mk:53:0$ rm -f ./mochitest-metro-chrome.log && t:/Mozilla/MC-REL/_virtualenv/Scripts/python.exe _tests/testing/mochitest/runtests.py --autorun --close-w
hen-done --console-level=INFO --log-file=./mochitest-metro-chrome.log --file-level=INFO --failure-file=t:/Mozilla/MC-REL/_tests/testing/mochitest/makefailures.json --testing-module
s-dir=t:/Mozilla/MC-REL/_tests/modules --extra-profile-file=./dist/plugins --build-info-json=t:/Mozilla/MC-REL/./mozinfo.json --symbols-path=./dist/crashreporter-symbols --metro-
immersive --browser-chrome
Usage: Usage instructions for runtests.py.
All arguments are optional.
If --chrome is specified, chrome tests will be run instead of web content tests.
If --browser-chrome is specified, browser-chrome tests will be run instead of web content tests.
See <http://mochikit.com/doc/html/MochiKit/Logging.html> for details on the logging levels.
runtests.py: error: no such option: --build-info-json
t:\Mozilla\mc\browser\build.mk:53:0: command 'rm -f ./mochitest-metro-chrome.log && t:/Mozilla/MC-REL/_virtualenv/Scripts/python.exe _tests/testing/mochitest/runtests.py --autorun
--close-when-done --console-level=INFO --log-file=./mochitest-metro-chrome.log --file-level=INFO --failure-file=t:/Mozilla/MC-REL/_tests/testing/mochitest/makefailures.json --testi
ng-modules-dir=t:/Mozilla/MC-REL/_tests/modules --extra-profile-file=./dist/plugins --build-info-json=t:/Mozilla/MC-REL/./mozinfo.json --symbols-path=./dist/crashreporter-symbols
--metro-immersive --browser-chrome' failed, return code 2
Blocks: 868158
Comment 2•11 years ago
|
||
Looks like Bug 903034 removed the --build-info-json option again, not sure why.
Blocks: 903034
Keywords: regression
Reporter | ||
Updated•11 years ago
|
Summary: pymake mochitest-metro-chrome fails with runtests.py: error: no such option: --build-info-json → pymake mochitest-* fails with runtests.py: error: no such option: --build-info-json
Reporter | ||
Comment 3•11 years ago
|
||
Reporter | ||
Comment 4•11 years ago
|
||
Comment on attachment 791690 [details] [diff] [review]
add back build-info-json
(In reply to Frank Wein [:mcsmurf] from comment #2)
> Looks like Bug 903034 removed the --build-info-json option again, not sure
> why.
Not sure, but adding it back fixes this bug.
Attachment #791690 -
Flags: review?(jgriffin)
Assignee | ||
Comment 5•11 years ago
|
||
Sorry, I didn't realize there were make targets still using this. There was a change in bug 903034 that should make --build-info-json unnecessary. Jim, does this patch work for you? If not then I don't mind just taking your patch for the time being.
Flags: needinfo?(jmathies)
Assignee | ||
Comment 6•11 years ago
|
||
Comment on attachment 792195 [details] [diff] [review]
remove build info json from mochitest make targets
Just verified the above patch fixes the problem for me. I'll get Jonathan to review while waiting for confirmation from Jim.
On a side note, while make targets are still supported, mach commands are the recommended way to run tests. To get around this problem in the meantime, you can either apply this patch, or just use ./mach mochitest-plain, etc..
Attachment #792195 -
Flags: review?(jgriffin)
Assignee | ||
Updated•11 years ago
|
Attachment #791690 -
Flags: review?(jgriffin)
Reporter | ||
Comment 7•11 years ago
|
||
Yes this appears to address the problem as well.
Flags: needinfo?(jmathies)
Updated•11 years ago
|
Attachment #792195 -
Flags: review?(jgriffin) → review+
Assignee | ||
Comment 8•11 years ago
|
||
Assignee: nobody → ahalberstadt
Status: NEW → ASSIGNED
Comment 9•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in
before you can comment on or make changes to this bug.
Description
•