906056 - Log exception in ttest.py

Status: RESOLVED FIXED

(Testing :: Talos, defect)

Description

[Dustin J. Mitchell [:dustin] (he/him)]

From bug 905350 comment 3:
> In the logs [1], you can also see a Debug message stating that there was an 
> unknown error during cleanup which does not throw a python traceback. That error 
> is coming from here:
> http://mxr.mozilla.org/build/source/talos/talos/ttest.py#230

That's a bare "except", which is generally undesirable, and furthermore it doesn't give any debug output about *what* exception occurred, which is certainly undesirable.

Comment 1

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: bug906056.patch

Comment 2

[cmtalbert]

Comment on attachment 791297 [details] [diff] [review]
bug906056.patch

Yes, I agree. Let's take this and get it up in production so we can see what is happening. Thanks!

Comment 3

[cmtalbert]

Oh you guys already solved the other bug. Let's take this anyway with the next update to Talos. Please go ahead and land it, and we'll pick it up next time we release talos.zip.

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

http://hg.mozilla.org/build/talos/rev/2a32cc64e7ff

landed, but still need to deploy.