Source mozconfig.common in SeaMonkey in-tree mozconfig files

RESOLVED FIXED in seamonkey2.23

Status

--
blocker
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mcsmurf, Assigned: neil)

Tracking

Trunk
seamonkey2.23

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
Recently Bug 904979 added a new configure option called --enable-release:
"
+  MOZ_ARG_ENABLE_BOOL(release,
+  [  --enable-release       Build with more conservative, release engineering-oriented options.],
+      DEVELOPER_OPTIONS=)"

It needs to be set to build with MOZILLA_OFFICIAL now. So we need to add --enable-release to our .mozconfig files, too. Or source build/mozconfig.common as that file also includes the option.

Currently trunk builds fail with this error:
configure: error: You cannot set MOZILLA_OFFICIAL without --enable-release

Comment 1

5 years ago
(In reply to Frank Wein [:mcsmurf] from comment #0)
> Currently trunk builds fail with this error:
> configure: error: You cannot set MOZILLA_OFFICIAL without --enable-release

Wait, what? I cannot enable crash reporter without --enable-release?
(Assignee)

Comment 2

5 years ago
Created attachment 791554 [details] [diff] [review]
Proposed patch

I assume this works, all the other mozconfigs do this except those mac ones which have their own common universal gubbins which RyanVM already fixed.
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #791554 - Flags: review?(bugspam.Callek)

Updated

5 years ago
Attachment #791554 - Flags: review?(bugspam.Callek) → review+
(Assignee)

Comment 3

5 years ago
Pushed comm-central changeset cd4633207251. Trees seem to be oranging up.
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.23
You need to log in before you can comment on or make changes to this bug.