Closed Bug 906140 Opened 6 years ago Closed 6 years ago

Source mozconfig.common in SeaMonkey in-tree mozconfig files

Categories

(SeaMonkey :: Build Config, defect, blocker)

defect
Not set
blocker

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.23

People

(Reporter: mcsmurf, Assigned: neil)

Details

Attachments

(1 file)

Recently Bug 904979 added a new configure option called --enable-release:
"
+  MOZ_ARG_ENABLE_BOOL(release,
+  [  --enable-release       Build with more conservative, release engineering-oriented options.],
+      DEVELOPER_OPTIONS=)"

It needs to be set to build with MOZILLA_OFFICIAL now. So we need to add --enable-release to our .mozconfig files, too. Or source build/mozconfig.common as that file also includes the option.

Currently trunk builds fail with this error:
configure: error: You cannot set MOZILLA_OFFICIAL without --enable-release
(In reply to Frank Wein [:mcsmurf] from comment #0)
> Currently trunk builds fail with this error:
> configure: error: You cannot set MOZILLA_OFFICIAL without --enable-release

Wait, what? I cannot enable crash reporter without --enable-release?
Attached patch Proposed patchSplinter Review
I assume this works, all the other mozconfigs do this except those mac ones which have their own common universal gubbins which RyanVM already fixed.
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #791554 - Flags: review?(bugspam.Callek)
Attachment #791554 - Flags: review?(bugspam.Callek) → review+
Pushed comm-central changeset cd4633207251. Trees seem to be oranging up.
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.23
You need to log in before you can comment on or make changes to this bug.