Closed Bug 906209 Opened 6 years ago Closed 6 years ago

spurious interface forward-declarations in a few idl files

Categories

(Core :: XPCOM, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla26

People

(Reporter: keeler, Assigned: keeler)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

The following idl files forward-declare the interfaces they're defining for no apparent reason:

xpcom/io/nsILineInputStream.idl
toolkit/profile/nsIToolkitProfile.idl
dom/interfaces/traversal/nsIDOMTreeWalker.idl
dom/interfaces/traversal/nsIDOMNodeIterator.idl

(to clarify, for example, see nsILineInputStream.idl:

...
6 
7 #include "nsISupports.idl"
8 
9 interface nsILineInputStream;
10 
11 [scriptable, uuid(c97b466c-1e6e-4773-a4ab-2b2b3190a7a6)]
12 interface nsILineInputStream : nsISupports
13 {
...

where nsILineInputStream is forward-declared for no reason that I see.)
Attached patch patchSplinter Review
This patch just removes the forward declarations (and some blank lines I didn't think were necessary).
bsmedberg - would you be able to have a look?
Attachment #791532 - Flags: review?(benjamin)
Comment on attachment 791532 [details] [diff] [review]
patch

Justin - this is what I pinged you about earlier. I also found a few more instances of the same thing. If this all looks good, I'll need sign-off from a DOM peer, I assume. Thanks!
Attachment #791532 - Flags: review?(justin.lebar+bug)
Comment on attachment 791532 [details] [diff] [review]
patch

sgtm if it compiles.
Attachment #791532 - Flags: review?(justin.lebar+bug)
Attachment #791532 - Flags: review?(benjamin)
Attachment #791532 - Flags: review+
Blocks: includehell
https://hg.mozilla.org/mozilla-central/rev/de5b7c7741e1
Assignee: nobody → dkeeler
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in before you can comment on or make changes to this bug.