906225 - Don't force developers to choose between --enable-release and mandatory ld.gold

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Justin Lebar (not reading bugmail)]

I've had to switch away from gold in the past because it broke valgrind.  I know someone else who can't use gold because linking completely freezes his machine.  The idea that now I have to choose between --enable-release and mandatory ld.gold feels pretty counterproductive.

I'm totally in favor of having sane defaults, but we're all adults here; I don't think we need to be taking away reasonable configuration options from developers, especially since we still support ld.bfd (afaik).

Comment 1

[Gregory Szorc [:gps]]

glandium: Can you address Justin's concerns?

Comment 2

[Steve Singer (:stevensn)]

Attachment: add_disable_gold.patch

I am finding that the version of gold that ships with debian wheezy (binutils 2.22-8) is broken on the powerpc, many of the programs that configure compiles and runs segfault on startup.

The attached patch adds a configure option to disable gold on a non-release build

Will this also solve Justin's issue?

Comment 3

[Mike Hommey [:glandium]]

Attachment: Add a --enable/disable-gold configure flag.

This allows to disable gold on developer builds, and to enable gold on release builds, if we ever feel like it.

Comment 4

[Mike Hommey [:glandium]]

Comment on attachment 801299 [details] [diff] [review]
add_disable_gold.patch

Thanks for the original patch.

Comment 5

[Gregory Szorc [:gps]]

Comment on attachment 810416 [details] [diff] [review]
Add a --enable/disable-gold configure flag.

Review of attachment 810416 [details] [diff] [review]:
-----------------------------------------------------------------

I didn't actually test this but LGTM.

Comment 6

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3b609dd4b505

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3b609dd4b505