Closed Bug 906225 Opened 7 years ago Closed 7 years ago

Don't force developers to choose between --enable-release and mandatory ld.gold

Categories

(Firefox Build System :: General, defect)

All
Linux
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla27

People

(Reporter: justin.lebar+bug, Assigned: glandium)

References

Details

Attachments

(1 file, 1 obsolete file)

I've had to switch away from gold in the past because it broke valgrind.  I know someone else who can't use gold because linking completely freezes his machine.  The idea that now I have to choose between --enable-release and mandatory ld.gold feels pretty counterproductive.

I'm totally in favor of having sane defaults, but we're all adults here; I don't think we need to be taking away reasonable configuration options from developers, especially since we still support ld.bfd (afaik).
No longer blocks: 904979
Depends on: 904979
glandium: Can you address Justin's concerns?
Flags: needinfo?(mh+mozilla)
Attached patch add_disable_gold.patch (obsolete) — Splinter Review
I am finding that the version of gold that ships with debian wheezy (binutils 2.22-8) is broken on the powerpc, many of the programs that configure compiles and runs segfault on startup.

The attached patch adds a configure option to disable gold on a non-release build

Will this also solve Justin's issue?
This allows to disable gold on developer builds, and to enable gold on release builds, if we ever feel like it.
Attachment #810416 - Flags: review?(gps)
Assignee: nobody → mh+mozilla
Status: NEW → ASSIGNED
Comment on attachment 801299 [details] [diff] [review]
add_disable_gold.patch

Thanks for the original patch.
Attachment #801299 - Attachment is obsolete: true
Comment on attachment 810416 [details] [diff] [review]
Add a --enable/disable-gold configure flag.

Review of attachment 810416 [details] [diff] [review]:
-----------------------------------------------------------------

I didn't actually test this but LGTM.
Attachment #810416 - Flags: review?(gps) → review+
https://hg.mozilla.org/mozilla-central/rev/3b609dd4b505
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
Flags: needinfo?(mh+mozilla)
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.