Open Bug 906232 Opened 6 years ago Updated 3 months ago

Remove all "diagnostic messages" from xpcshell tests

Categories

(Testing :: XPCShell Harness, task, P5)

task

Tracking

(Not tracked)

People

(Reporter: fitzgen, Unassigned)

References

(Blocks 1 open bug)

Details

I have been adding strings for what each assertion is testing (eg, do_check_true(foo, "message")). Turns out that I've been doing it wrong and that parameter is actually for a stack that you can pass in to say where the error came from. This overrides the normal stack, so we lose location information about which error is failing. Woops!
OS: Mac OS X → All
Priority: -- → P3
Hardware: x86 → All
The xpcshell harness is kind of dumb, this doesn't match what every other test harness in the world does. Maybe we should just fix the harness to have a description parameter, and shift stack back one? I can't imagine anyone is actually passing in a stack there (aside from the harness itself).
Fixing the harness seems like the right thing to do. Bobby, what do you think we should do here?
Flags: needinfo?(bobbyholley)
I agree that we should just fix the harness, but it's kind of irrelevant because this is a bug in the harness which ted owns (not I).
Flags: needinfo?(bobbyholley)
Blocks: dbg-test
Product: Firefox → DevTools

Nick, Bobby is this still relevant? Also what is the right bugzilla component for it if it is?

Type: defect → task
Priority: P3 → P5

(In reply to Jason Laster [:jlast] from comment #4)

Nick, Bobby is this still relevant? Also what is the right bugzilla component for it if it is?

May or may not be relevant, moving it to the right component.

Component: Debugger → XPCShell Harness
Product: DevTools → Testing
You need to log in before you can comment on or make changes to this bug.