Closed
Bug 906327
Opened 13 years ago
Closed 13 years ago
crash in about:networking
Categories
(Core :: Networking, defect)
Tracking
()
RESOLVED
FIXED
mozilla26
People
(Reporter: robertbindar, Assigned: robertbindar)
Details
Attachments
(1 file, 1 obsolete file)
|
1019 bytes,
patch
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:23.0) Gecko/20100101 Firefox/23.0 (Beta/Release)
Build ID: 20130803192641
Steps to reproduce:
Click between the menu buttons and a javascript "content is null" will occur.
|
Assignee | |
Comment 1•13 years ago
|
||
Attachment #791695 -
Flags: review?(valentin.gosu)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 791695 [details] [diff] [review]
crash_menu_buttons.patch
Review of attachment 791695 [details] [diff] [review]:
-----------------------------------------------------------------
Check with Gavin or Tim if this is the right way to verify the target.
Attachment #791695 -
Flags: review?(valentin.gosu) → review+
|
||
Comment 3•13 years ago
|
||
An explicit target check would be better - "!= this" is rather imprecise. Maybe e.target.parentNode == menu?
|
|
Assignee | |
Comment 4•13 years ago
|
||
Fine by me, I will resend it today. r=valentin.gosu or should I ask for review again?
|
|
Assignee | |
Comment 5•13 years ago
|
||
Attachment #791695 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•13 years ago
|
Keywords: checkin-needed
|
||
Comment 6•13 years ago
|
||
Assignee: nobody → robertbindar
Keywords: checkin-needed
|
|
||
Updated•13 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
|
|
||
Comment 7•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in
before you can comment on or make changes to this bug.
Description
•