Closed Bug 906327 Opened 7 years ago Closed 7 years ago

crash in about:networking

Categories

(Core :: Networking, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla26

People

(Reporter: robertbindar, Assigned: robertbindar)

Details

Attachments

(1 file, 1 obsolete file)

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:23.0) Gecko/20100101 Firefox/23.0 (Beta/Release)
Build ID: 20130803192641

Steps to reproduce:

Click between the menu buttons and a javascript "content is null" will occur.
Attached patch crash_menu_buttons.patch (obsolete) — Splinter Review
Attachment #791695 - Flags: review?(valentin.gosu)
Comment on attachment 791695 [details] [diff] [review]
crash_menu_buttons.patch

Review of attachment 791695 [details] [diff] [review]:
-----------------------------------------------------------------

Check with Gavin or Tim if this is the right way to verify the target.
Attachment #791695 - Flags: review?(valentin.gosu) → review+
An explicit target check would be better - "!= this" is rather imprecise. Maybe e.target.parentNode == menu?
Fine by me, I will resend it today. r=valentin.gosu or should I ask for review again?
Attached patch crash_menu.patchSplinter Review
Attachment #791695 - Attachment is obsolete: true
Keywords: checkin-needed
Status: UNCONFIRMED → NEW
Ever confirmed: true
https://hg.mozilla.org/mozilla-central/rev/cba433799e1b
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in before you can comment on or make changes to this bug.